Expose clojurescript repl-env directly #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternative to, and builds heavily upon, bhauman#457 (big thanks to to @Deraen) It exposes the repl-env in the same way, and is intended for vim-fireplace. Example usage from vim-fireplace: ```vim :Piggieback (figwheel-sidecar.repl-api/repl-env) ```
bhauman
reviewed
Sep 26, 2016
| @@ -83,7 +83,10 @@ | |||
| (first (string/split x #"\?"))))) | |||
| stack-trace)) | |||
|
|
|||
| (defrecord FigwheelEnv [figwheel-server] | |||
| (defrecord FigwheelEnv [figwheel-server repl-opts] | |||
| cljs.repl/IReplEnvOptions | |||
There was a problem hiding this comment.
It's important to know what version of CLJS introduced this IReplEnvOptions. Is this going to cause legacy nightmares or has it been around long enough that this isn't a problem.
There was a problem hiding this comment.
First version to include this should be 0.0-2719
bhauman
reviewed
Sep 26, 2016
| opts)] | ||
| (assoc figwheel-repl-env | ||
| ;; these are merged to opts by cljs.repl/repl* | ||
| :repl-opts repl-opts)))) |
There was a problem hiding this comment.
Again how many version back has this :repl-opts merging been going on.
There was a problem hiding this comment.
This was added in the same commit as the IReplEnvOptions. cljs.repl/repl* doesn't directly use this :repl-opts key but instead calls the -repl-options method of the protocol and after this PR FigwheelRepl record implements that method and uses repl-opts property.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to, and builds heavily upon,
#457 (big thanks to to
@Deraen)
It exposes the repl-env in the same way, and is intended for
vim-fireplace.
Example usage from vim-fireplace:
Tested via:
in vim:
I was able to use
Kto view docs, evaluate code, and jump to source.