Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on itertools >=0.10, <0.12 #695

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

sjackman
Copy link
Contributor

Depend on itertools >=0.10, <0.12

@sjackman
Copy link
Contributor Author

error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256' to 'C:\Users\appveyor\.rustup\tmp\81ucn_6cqhsxtqhp_file': failed to make network request: error sending request for url (https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256): error trying to connect: The message received was unexpected or badly formatted. (os error -2146893018): error trying to connect: The message received was unexpected or badly formatted. (os error -2146893018): The message received was unexpected or badly formatted. (os error -2146893018) Command exited with code 1
https://ci.appveyor.com/project/bheisler/criterion-rs/builds/47373637/job/agikfswe8n4heksh#L16

@sjackman
Copy link
Contributor Author

In the previous build https://ci.appveyor.com/project/bheisler/criterion-rs/builds/47373637
✅ Environment: TARGET=x86_64-pc-windows-msvc, GNUPLOT=yes
❌ Environment: TARGET=x86_64-pc-windows-msvc, GNUPLOT=no

In the current build (with no change to code) https://ci.appveyor.com/project/bheisler/criterion-rs/builds/47373729
❌ Environment: TARGET=x86_64-pc-windows-msvc, GNUPLOT=yes
❌ Environment: TARGET=x86_64-pc-windows-msvc, GNUPLOT=no

@sjackman
Copy link
Contributor Author

sjackman commented Jul 7, 2023

@lemmih Is there anything I need to change in this PR to get the AppVeyor CI check passing?

@lemmih
Copy link
Collaborator

lemmih commented Jul 7, 2023

@lemmih Is there anything I need to change in this PR to get the AppVeyor CI check passing?

You could make a separate PR that gets rid of AppVeyor.

@sjackman
Copy link
Contributor Author

sjackman commented Jul 10, 2023

You could make a separate PR that gets rid of AppVeyor.

Done!

@sjackman
Copy link
Contributor Author

@lemmih Thank you for merging my PR #699 to remove AppVeyor! Looks like this PR is now passing CI and good to go.

@lemmih lemmih merged commit e743d5e into bheisler:master Aug 15, 2023
4 checks passed
@sjackman sjackman deleted the sj/itertools branch October 2, 2023 17:26
@sjackman
Copy link
Contributor Author

@lemmih Thank you for merging this PR, David. Could you please push a new stable release to crates.io including this change when you have time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants