Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to prefix units to currency amounts #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quarkw
Copy link

@quarkw quarkw commented May 28, 2023

This can be useful when copying amounts where the $ or other currency symbol comes before the numeric amount, as is standard in some countries

I did not change the default workflow configuration, so to actually use this, you would have to add a custom keyword to use the workflow, for example, conv.

And use it like:

conv $100 to EUR

Due to the way the converter works, the following would also work:
conv USD100 to EUR

For convenience, we could add all the currency symbols as keywords, but that may not be very maintainable when adding/removing new currencies. But, that would allow queries such as:
$100 to work automatically

@biati-digital
Copy link
Owner

Hi, thank's for the PR. This workflow was only created to avoid using keywords, having to add a keyword to use your changes defeats the entire purpose of the workflow.

I can not accept this PR but thank's anyway.

@quarkw
Copy link
Author

quarkw commented May 28, 2023

Hi, thank's for the PR. This workflow was only created to avoid using keywords, having to add a keyword to use your changes defeats the entire purpose of the workflow.

I can not accept this PR but thank's anyway.

If I modified the PR to change the workflow configuration to work without keywords (work with the symbols automatically) would that be acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants