Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privilege to apply stylesheet to Bible #859

Closed
2 tasks done
warpok opened this issue Jan 12, 2023 · 20 comments
Closed
2 tasks done

Privilege to apply stylesheet to Bible #859

warpok opened this issue Jan 12, 2023 · 20 comments

Comments

@warpok
Copy link

warpok commented Jan 12, 2023

  • Fix issue.
  • Create Ubuntu package

Today I taught Ninda how to put make and modify a new stylesheet. She named it Style sheet Ninda. As an example, I had her turn the verse numbers red. This was being done in her account. She was sharing her screen by Zoom and I was giving instructions. She was working in the cloud interface.

Now look what I find in my workspace here using Bibledit cloud:
Screenshot 2023-01-12 9 34 17 AM

Ninda is not a manager.
Screenshot 2023-01-12 9 39 05 AM

But she as a translator has changed my setting for which editor is used in my account.
Screenshot 2023-01-12 9 39 51 AM

@warpok
Copy link
Author

warpok commented Jan 12, 2023

Surely you don't intend it to work this way, right?

@teusbenschop
Copy link
Member

This is not intended to be so.
That red squiggly line is not something that the stylesheet can generate, it cannot generate a red squiggly line below a word.
Is that red squiggly line generated by her device, by the spelling checker or the grammar checker, or another checker?

@warpok
Copy link
Author

warpok commented Jan 13, 2023 via email

@teusbenschop
Copy link
Member

This picture:
Screenshot 2023-01-13 at 14 22 30
what is the device brand and operating system this occurs on?

@warpok
Copy link
Author

warpok commented Jan 13, 2023 via email

@teusbenschop
Copy link
Member

It is great that Chrome allows the user to do a spell check.
But then if this is the case, then the red squiggly line is not related to Bibledit, right?
If this is the case, can this bug be closed, or do you intent to suppress the red squiggly lines?

@warpok
Copy link
Author

warpok commented Jan 14, 2023

The bug has nothing to do with the squiggly lines. The bug is that when Ninda (a translator) makes a new style sheet then activated it for displaying our project, her style sheet (probably) got sent to all the translators and at least to me as the manager. It might be that her style sheet was contagious only to team members currently online. I didn't ask anyone else if they suddenly now have red superscript verse numbers. I will ask them.

@teusbenschop
Copy link
Member

If Linda, a translator, creates a new stylesheet, then this stylesheet is immediately available to the other users. And if she selects this new stylesheet for displaying a given Bible, then this stylesheet is connected to that Bible. So anyone else who is going to display this Bible will automatically use the stylesheet connected to that Bible.

It is not a bug, it it is designed to be this way.

@warpok
Copy link
Author

warpok commented Jan 17, 2023

So Suzie Q, a translator, decides she wants large pink italic verse numbers, and large font purple text for headings. She makes her style sheet and chooses it for displaying the Bible, and all the members of the team suddenly get surprised when they start work the next morning. Sounds like a good joke!

Screenshot 2023-01-17 3 52 43 PM

I suggest that individual translators be allowed to be creative with their style sheet modifications and be permitted to display them. And if other translators like the modifications, they can choose to activate the same style sheet. A style sheet for editing is like the Preference settings. Not everyone wants the same thing.

If you want to opt for one-size-fits-all style sheets, then only the admin and managers should be able to set them for the group.

In our case, Ninda is making screenshots of the Psalms for sharing in Whatsapp groups. We want the appearance to be kind of like our typeset output. But I want some modifications as I am working on the Psalms now. I like to have \q2 set to italic font, so I can tell at a glance what is q1, q2, and q3.

So this is one reason to enable translator-level style sheets.

@teusbenschop
Copy link
Member

I agree with your observation and suggestion to have a user-level stylesheet for displaying a Bible.

would you be able to update the title of this issue to reflect this? It's now given as a "bug", but it is not a bug since it was designed to be so.

@warpok warpok changed the title bug in stylesheets enhancement for user-level stylesheets Jan 20, 2023
@warpok
Copy link
Author

warpok commented Jan 20, 2023

Gladly! Done.

@teusbenschop teusbenschop self-assigned this Feb 17, 2023
@teusbenschop teusbenschop changed the title enhancement for user-level stylesheets Personal setting for stylesheets Feb 17, 2023
@teusbenschop
Copy link
Member

Thinking about this for a bit more, I think this one is the easiest to implement:

If you want to opt for one-size-fits-all style sheets, then only the admin and managers should be able to set them for the group.

It looks like if someone wants to be creative with a stylesheet, then Bibledit is not intended for such creativity, and one can just be creative in other software environments. So if the manager decides to create or edit a stylesheet that suits the needs of this Bible, then it's a matter of discussing this with the team and settling on styles by democratic vote, and so then the manager can set a stylesheet for the whole project.

This would focus the main purpose of Bibledit, which is editing Bibles, rather than having fancy colours in the editor.

@oreowarpok
Copy link

Teus, I think that our conversation got side-tracked by several rabbit trails. 'Getting creative' with stylesheets was kind of a far out example.

Getting back to the point of this issue at the beginning, Ninda had a legitimate use for having a different stylesheet than me. She is sharing PDFs and screenshots of Bibledit in her work of managing our Whatsapp checking groups.
On the other hand, I also have a legitimate use for having a different editing stylesheet. I am still working on Psalms, and I like to have the q2 indented lines with an obvious font difference, so that I can quickly see which lines are q1, q2, and q3. I also like to have big verse numbers while editing.

I have been mainly interested in the editor stylesheets. Now I wonder if the print stylesheets also allow for each user to set the printing stylesheet for the whole group. One problem is that I cannot tell the purpose a stylesheet was created, whether it is for editing or printing. In my mind, it would be good to keep them separate. [New issue?]

  • I probably have a larger team than most other teams using Bibledit. Most other teams will not have differing needs like we sometimes do.
  • I have not taught our team members how to change stylesheets, so most of them have not changed them.
  • If Bibledit is basically set up to have one active stylesheet for editing and one for printing, then I think that Managers and Admin should be the only ones able to change them. Translators wanting something different should talk with the managers/admin to see if the request is something all team members can use, at least for a period of time.
  • Having personal settings would be OK too, and that is what I assumed that Bibledit could do, since everyone had the ability to change the stylesheets. But for me as a manager and admin, the current situation is weird and could cause extra work, since I can't tell who created what stylesheets, unless they happened to use their name to identify their creation. Then I ask, "What purpose did Manoel have for creating a stylesheet?" I don't want to delete until I find out if he had a good formatting idea.

So yes, I still agree. Given the way Bibledit is set up, let's have stylesheets be editable only by managers and admin. Thanks for your thoughtful considering this.

@teusbenschop teusbenschop removed their assignment Feb 20, 2023
@teusbenschop teusbenschop self-assigned this Feb 20, 2023
@teusbenschop
Copy link
Member

Thanks for getting the conversation back on topic again.

I did find out who exactly has the privileges to change the stylesheet used for editing a Bible and for exporting a Bible.

It appears that anyone who has "write" access to a Bible, can really exercise that write access, and therefore can change a stylesheet too.

Once someone has write access, that person can make any changes to the text in that Bible. But the other member of the team can give feedback on those changes, and so there's several mechanisms of control on what the user with write access does. In view of those many privileges that person has, it seems entirely logical that such a person, with write access to a Bible, can not only change the text of that Bible, but can also change the stylesheet of that Bible. Changing Bible text has more impact than changing a stylesheet. So why limiting those rights or privileges?

One of the main design philosophies of Bibledit is that this is some piece of software that is designed to hand responsibilities and trust to users. I guess taking away rights does not fit in this design philosophy.

If someone has been entrusted with translation privileges, that is not a small thing. Let's not take away from those entrusted privileges by limiting things that a translator easily should be able to handle.

@oreowarpok
Copy link

Everything is up to you. I respect you for all that you have done to make this program which has been so instrumental in the success of our translation team.

However, I must admit that I disagree on this point. It doesn't seem to me that your logic is consistent. For instance, you have made it so that the managers/admin can determine which team members can edit which books. Managers can determine what checks are performed, and I think I noted recently that ordinary translators cannot. Consultants can't change the text. I think that ordinary translators cannot delete a Bible project or add books to an existing project. Only managers and admin (I think) can do that. As a manager, I can determine if the translators can delete consultant notes or use advanced mode in the Cloud. How is it consistent with such limitations for translators to give them power over stylesheets?

Changing a stylesheet is not an intuitive process. Most of our members haven't messed with them. Why is it that even managers can't delete any stylesheet except the ones they create themselves. Only Admin can delete all user-edited stylesheets. No one can see who created a stylesheet, unless the user used his name in the name of the stylesheet. So currently, the situation with stylesheets is a little island of anarchy in the normally managed Bibledit interface.

However, it is unlikely that keeping the program the same will cause any serious problem. I will just tell all of our team to check with me about any changes they want to make in stylesheets.

@teusbenschop
Copy link
Member

You have pointed out some inconsistency in the privileges assigned to the translators. I agree that there's some inconsistency there. Then to make it more consistent, there's two, or perhaps, more ways to do that.

  1. One can apply more limits to the privileges of the translators.
  2. One can remove some current limits allowing translators to do such tasks again.

Both cases will remove some inconsistencies, and perhaps add some inconsistencies again.

Bibledit as it was designed gives more freedoms to the user rather than less freedoms.

@oreowarpok
Copy link

Great!

After I wrote to you, I thought of a good way to make the change and still allow flexibility in the freedoms given to translators. It would be to add a checkbox for Can edit stylesheets to
Settings > Users > edit (in the Privileges column).

You could make the default to be on (according to your preference), or off (according to mine). ;-)

@teusbenschop
Copy link
Member

This approach sounds reasonable.

teusbenschop added a commit that referenced this issue Mar 1, 2023
@teusbenschop
Copy link
Member

The action of editing a stylesheet is already a privileged action. Someone who created the stylesheet automatically receives the privilege to also edit it. This is natural and looks consistent.

The only privilege that now remains to be controlled is the action to apply a stylesheet to a Bible.

The difference is to "edit" it, or to "apply" it.

Therefore any code changes made here only refer to applying the stylesheet to a Bible.

@teusbenschop teusbenschop changed the title Personal setting for stylesheets Privilege to apply stylesheet to Bible Mar 1, 2023
teusbenschop added a commit that referenced this issue Mar 1, 2023
@teusbenschop
Copy link
Member

Finally an Ubuntu package for bibledit-cloud was built, and is available as normal. The version is 5.0.996, see the PPA at https://code.launchpad.net/~bibledit/+archive/ubuntu/ppa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants