PrivateSend - Unable to Mix Coins - Invalid Collateral?

[togosh]

Documentation:
https://wiki.biblepay.org/PrivateSend

debug.log:

CMasternodeMan::FindRandomNotInVec -- 173 enabled masternodes, 20 masternodes to choose from

CPrivateSendClientSession::StartNewQueue -- attempt 0 connection to Masternode XXXX

CPrivateSendClientSession::StartNewQueue -- pending connection, nSessionDenom: 1 (10.01), addr=XXXX

CPrivateSendClientSession::CheckPoolStateUpdate -- entry is rejected by Masternode

CPrivateSendClientSession::DoAutomaticDenominating -- invalid collateral, recreating...

keypool added key XXXX, size=100000, internal=0

init message: Loading wallet... (822.47 %)

CMasternodeMan::FindRandomNotInVec -- 172 enabled masternodes, 85 masternodes to choose from

CPrivateSendClientSession::StartNewQueue -- attempt 0 connection to Masternode XXXX

CPrivateSendClientSession::StartNewQueue -- pending connection, nSessionDenom: 1 (10.01), addr=XXXX

CPrivateSendClientSession::CheckPoolStateUpdate -- entry is rejected by Masternode

ThreadRPCServer incorrect password attempt from XXXX

CPrivateSendClientSession::DoAutomaticDenominating -- invalid collateral, recreating...

bool CPrivateSendClientSession::DoAutomaticDenominating
https://github.com/biblepay/biblepay-evolution/blob/master/src/privatesend-client.cpp#L798

if (!CPrivateSend::IsCollateralValid(txMyCollateral))
https://github.com/biblepay/biblepay-evolution/blob/master/src/privatesend-client.cpp#L910

bool CPrivateSend::IsCollateralValid
https://github.com/biblepay/biblepay-evolution/blob/master/src/privatesend.cpp#L325

[biblepay]

Is this still broken?

[togosh]

I've rented three servers, set up 3 wallets, sent 10k coins to each and started mixing,
Ill let them run for a day and report back

[togosh]

NOTE: I did notice that the coins were getting split up into 10, 1, 0.1, and 0.01 denominations

I believe in past, due to us having much higher coin supply than Dash,
we removed 0.1 and 0.01 and added 100, 1,000 and 10,000
https://www.reddit.com/r/BiblePay/comments/8avfaj/privatesend_coin_mixing_denominations_increased/

[sunk818]

Remember PrivateSend Basics text needs to be updated too.

[togosh]

Reporting Back:
Full debug.log file from 3rd mixing machine
https://uploadfiles.io/59mkh608 (145mb file, expires in 30 days)
I do not believe any coins mixed on any machines,
I setup a 4th machine with GUI, all the coins got denominated, but no mixing

[biblepay]

Lets try to nail this down in TestNet, since that will be our next major upgrade.

Ill get these denominations updated - then released - then we can re-test with those deterministic sancs. I have a feeling that the slow and broken mixing is due to the vast difference in denomination size (like you mentioned above). Also being deterministic, the mixing should be much much more reliable and faster in testnet.

Ill make a post as soon as its ready.

[MIPPL]

@togoshige please contact me in discord so we can test this in a more fluid way. Thanks.

[biblepay]

We should have a new testnet thread open within the next 7 days. Since Dash changed so much of PS in LLMQ it would be worth testing again in testnet against the new LLMQ 5_60 quorums (these are two per day), to see if PS works flawlessly in DM mode. If it does work in testnet Im confident it will work in prod in September.