Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIbleTime 3.0 installs /usr/bin/DisplayView.qml on Linux #260

Closed
jaakristioja opened this issue Aug 3, 2020 · 3 comments
Closed

BIbleTime 3.0 installs /usr/bin/DisplayView.qml on Linux #260

jaakristioja opened this issue Aug 3, 2020 · 3 comments
Assignees
@gholmlund
Labels
component: Build system component: Packaging/Releases resolution: FIXED The issue is fixed. Instructions from comments might have to be followed to resolve this locally. type: BUG
Milestone
3.0.1

Comments

@jaakristioja
Copy link
Member

jaakristioja commented Aug 3, 2020 •
edited

As noted by @greg-hellings, on Linux BIbleTime 3.0 installs the /usr/bin/DisplayView.qml file which is probably not needed.

This seems to be caused by the QTBUG-55259 workaround in cmake/BTApplication.cmake:178-185 which installs the file even for non-affected platforms.
@jaakristioja jaakristioja added this to the 3.0.1 milestone Aug 3, 2020
@gholmlund
Copy link
Contributor

The Display.qml file is required to be present for the display of text windows. The only choice is what path it is located on. Currently there is no other path setup where it could be moved to without some changes in code. Perhaps it can be compiled in as a resource file.

@greg-hellings
Copy link
Contributor

I'll just package it with Bible Time for now in Fedora. That is, unless the patch point is easy to relocate it. Hopefully we can figure another place for it to live later.

gholmlund pushed a commit that referenced this issue Aug 6, 2020
Fix bug #260 Move DisplayView.qml to share/bibletime/qml
7700e93
gholmlund pushed a commit that referenced this issue Aug 6, 2020
Fix bug #260 Move DisplayView.qml to share/bibletime/qml
15bb149
@gholmlund
Copy link
Contributor

@greg-hellings For linux only cmake/BTApplications.cmake and src/frontend/display/modelview/btquickwidget are needed.

@jaakristioja jaakristioja added the resolution: FIXED The issue is fixed. Instructions from comments might have to be followed to resolve this locally. label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gholmlund gholmlund

Labels
component: Build system component: Packaging/Releases resolution: FIXED The issue is fixed. Instructions from comments might have to be followed to resolve this locally. type: BUG
Milestone
3.0.1
Development

No branches or pull requests
3 participants
@greg-hellings @jaakristioja @gholmlund