Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Kobo Support #101

Closed
wants to merge 53 commits into from
Closed

Basic Kobo Support #101

wants to merge 53 commits into from

Conversation

ragusa87
Copy link
Contributor

@ragusa87 ragusa87 commented May 24, 2024

  • Allow syncing some specifics shelves to your Kobo
  • So far, there is some DB changes and migration stuff to be discussed.
  • All secret reported by bitguardian where false-positive from examples json. I could not ignore them (Docker scans do not use ignored-paths configuration option GitGuardian/ggshield#548) so I rebased the MR without theses files.
  • I had trouble with using migration as the first "schema creation" was not into a migration, I fixed it.

Copy link

gitguardian bot commented May 24, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7911963 Triggered Generic Password f2aed59 docker-compose.yml View secret
7911963 Triggered Generic Password f2aed59 docker-compose.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@ragusa87 ragusa87 marked this pull request as draft May 24, 2024 13:56
@ragusa87 ragusa87 force-pushed the main branch 8 times, most recently from 0fbfb8f to c1b9a6e Compare May 25, 2024 09:03
@SergioMendolia SergioMendolia self-assigned this May 25, 2024
Copy link
Collaborator

@SergioMendolia SergioMendolia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A discuter ensemble

config/packages/security.yaml Outdated Show resolved Hide resolved
rector.php Outdated Show resolved Hide resolved
src/Controller/KoboNextReadController.php Outdated Show resolved Hide resolved
src/Entity/Kobo.php Outdated Show resolved Hide resolved
src/Kobo/DownloadHelper.php Outdated Show resolved Hide resolved
src/Kobo/DownloadHelper.php Outdated Show resolved Hide resolved
src/Kobo/ImageProcessor/CoverTransformer.php Outdated Show resolved Hide resolved
return;
}
list($originalWidth, $originalHeight) = $sizes;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use imaginebundle?

Copy link
Contributor Author

@ragusa87 ragusa87 May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can discuss this, but it seems complicated to me.

  • Echo Device can ask for different size
  • I don't think it's usefull to store theses covers
  • I have no idea how to integreate imagineBundle to resize "on the fly".

src/Menu/MenuBuilder.php Outdated Show resolved Hide resolved
@ragusa87 ragusa87 force-pushed the main branch 2 times, most recently from 3e8f136 to 5cce470 Compare May 31, 2024 15:01
@SergioMendolia
Copy link
Collaborator

closed because merge in another pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants