Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] add "dir" to the list of func entities #99

Merged
merged 1 commit into from
Dec 29, 2020
Merged

[FIX] add "dir" to the list of func entities #99

merged 1 commit into from
Dec 29, 2020

Conversation

Remi-Gau
Copy link
Collaborator

dir was not listed as one of the entities for the func modalities.

This led to some bug on our side: cpp-lln-lab/bidspm#194

The func name template is this one:

sub-<label>[_ses-<label>]_task-<label>[_acq-<label>][_ce-<label>][_dir-<label>][_rec-<label>][_run-<index>][_echo-<index>]_<contrast_label>.nii[.gz]

The current entities we support are:

    func_entities = {'sub', ...
                     'ses', ...
                     'task', ...
                     'acq', ...
                     'rec', ...
                     'fa', ...
                     'echo', ...
                     'inv', ...
                     'run', ...
                     'recording', ...
                     'meta'};

I see quite a few other mismatch in there. @gllmflndn am I missing something or shouldn't we also:

  • add ce
  • remove fa, inv, recording

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Nov 28, 2020

Also we only support bold as contrast label for now and cbv and phase are also in the specs.

This seems more of an edge case at the moment and might require more coding that could be rendered moot when we have a schema to help us. So I would suggest that we open an issue for this point (to remind ourselves and let others know we know) but do not move on to fix it right away.

@Remi-Gau Remi-Gau added this to In progress in General Kanban Dec 29, 2020
@Remi-Gau Remi-Gau mentioned this pull request Dec 29, 2020
3 tasks
@Remi-Gau
Copy link
Collaborator Author

Unless I am mistaken there is no dataset in bids-example with a dir entity so there is no convenient way to add a test for this one.

So I will merge for now and make a note to add a test for this... Later.

@Remi-Gau Remi-Gau merged commit 063f885 into bids-standard:master Dec 29, 2020
General Kanban automation moved this from In progress to Done Dec 29, 2020
@Remi-Gau Remi-Gau deleted the remi-parse_func branch January 13, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant