-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] BEP 020 Eye Tracking #1128
base: master
Are you sure you want to change the base?
Conversation
correction of text
(NOTE: I'll cross-post this message across several BEP threads) Hi there, just a quick notification that we have just merged #918 and it may be interesting to look at the implications for this BEP. We are introducing "BIDS URIs", which unify the way we refer to and point to files in BIDS datasets (as opposed to "dataset-relative" or "subject-relative" or "file-relative" links). If the diff and discussion in the PR is unclear, you can also read the rendered version: https://bids-specification.readthedocs.io/en/latest/02-common-principles.html#bids-uri Perhaps there are things in the BEP that need adjusting now, but perhaps also not -- in any case it's good to be aware of this new feature! Let me know if there are any questions, comments, or concerns. |
…-recordings.md Co-authored-by: Remi Gau <remi_gau@hotmail.com>
@Remi-Gau @mszinte I'm struggling with keeping
|
I have resynced with master after #1749 and #1750 have been finalized and merged. I believe the proposal is now more readable (cc/ @mszinte, @julia-pfarr). There are still some minimal wrinkles, but I think overall, it is looking good. I'll try to find time for the BIDS Validator before our meeting next week. |
@Remi-Gau one more question about the schema. I think it'd be ideal that the timestamp column was the first one (when present). However, it looks like required columns are always pushed first in the spec. What should we do here? |
Pretty sure that there is a precedent for column order in the schema. Need to check. |
"pupil_size": { | ||
"Description": "Pupil area of the recorded eye as calculated by the eye-tracker in arbitrary units (see EyeLink's documentation for conversion).", | ||
"Units": "a.u." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this only describes pupil_size but the tsv content below has 4 columns, wouldn't it be better to have all 4 described?
I think that users can figure it out but I would prefer to avoid having users interprate the specification and be explicit about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put all descriptions to be written in the json file by the converter...I thought this was just an example to show that all descriptions should be present
<<a href="../glossary.html#data_type-common_principles">datatype</a>>/ | ||
<matches>[_<a href="../appendices/entities.html#recording">recording</a>-<<a href="../glossary.html#label-common_principles">label</a>>]_<<a href="../glossary.html#physio-suffixes">physio</a>|<a href="../glossary.html#physioevents-suffixes">physioevents</a>><a href="../glossary.html#json-extensions">.json</a> | ||
<matches>[_<a href="../appendices/entities.html#recording">recording</a>-<<a href="../glossary.html#label-common_principles">label</a>>]_<<a href="../glossary.html#physio-suffixes">physio</a>|<a href="../glossary.html#physioevents-suffixes">physioevents</a>><a href="../glossary.html#tsvgz-extensions">.tsv.gz</a> | ||
</code></pre></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK shouldn't be HTML here -- I can't read it... Use MACRO as below or demonstrate on a simple Text
example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem is that that matches
is not in the glossary so we can't have macro yet.
Opened this so we can have it in the glossary and then after make it easier to MACRO the 💩 out of this.
#1781
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also: #1128 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and also... all PRs are rendered as HTML: https://bids-specification--1128.org.readthedocs.build/en/1128/modality-specific-files/physiological-recordings.html#physiology-events
😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK shouldn't be HTML here -- I can't read it... Use MACRO as below or demonstrate on a simple
Text
example?
Yes, we're using this to set some expectation for the macros to deal with this.
"Columns": ["onset", "duration", "trial_type", "blink", "message"], | ||
"Description": "Messages logged by the measurement device", | ||
"ForeignIndexColumn": "timestamp", | ||
"blink": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shameless plug: this is the situation I would like to avoid in
where I guess such file would look like
{
"Description": "Messages logged by the measurement device",
"ForeignIndexColumn": "timestamp",
"Columns": {
"onset": { "Index": 1},
"duration": {"Index": 2},
"trial_type": {
"Description": "Event type as identified by the eye-tracker's model (either 'n/a' if not applicabble, 'fixation', or 'saccade')."
"Index": 3},
"blink": {
"Description": "One indicates if the eye was closed, zero if open."
"Index" : 4},
"message": {
"Description": "String messages logged by the eye-tracker.",
"Index": 5}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1 on this and the solution.
However, I understand that can only be implemented in BIDS 2.0 because would introduce backward breaking changes, right?
If so, I think this is something we cannot resolve here :(
Sorry, I haven't been following this, but if adding a timestamp column is an issue, have you looked at blood for prior art, which has a |
It is not an issue (other than whether we are correctly configuring the schema #1128 (comment) and allowing an optional column to be placed first in the file when there are two mandatory columns after) It seems that most of the ET devices do generate a timestamp/time column, so that would not be problematic at all. |
Some metadata of the `StimulusPresentation` object become REQUIRED with the presence of | ||
[eye-tracking data](physiological-recordings.md#eye-tracking) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned yesterday in the meeting: only for on-screen eyetracking.
Makes the validation of those a bit more complicated (one extra If).
I wonder if we should not have a similar warning in the eyetracking section, or at least a link to the task page.
@rwblair can we get your input about allowing/validating optional columns to be present (when present) before mandatory columns? |
|
The number of calibrations corresponding to this run. | ||
type: integer | ||
minimum: 0 | ||
CalibrationPosition: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assumes the same position for all calibrations / validations
} | ||
``` | ||
|
||
Content of `sub-01_task-VisualSearch_events.json`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really the _events.json file or is it the _physioevents.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct, it annotates the events.tsv file, as opposed to the new _physioevents.json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So basically in the _physioevents.json file I only have the column names plus their description? And do I need a _events.json file if I do not have an _events.tsv? Because Martins dataset on Open Neuro does not have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, gotcha -- you've actually hit an edge case we do not currently cover:
- We say that some metadata belonging in the
_events.json
file becomes mandatory if eye tracking is present - However, BIDS allows
task-rest
to dismiss the events.tsv file. This BEP could make it mandatory for rest, even if theevents.tsv
file is just empty (only the header row).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or include it in the physioevents.json
? (if this does not disturb too much other stuff) Because that would be easy to include in the converter as we are already asking users to put some metadata manually in themetadata.yml
which is read in by our code. The current code actually does that because I understood it wrong, cf my initial question...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure that is a good idea. If I were to move the metadata from events.json, I would think it'd be better in the physio.json file rather than physioevents.json.
These metadata are about stimulus presentation, so they are likely relevant beyond eye tracking exclusively. Perhaps a reasonable alternative would be to update the specs so these metadata are encoded within stim.json files instead of the events.json files. Either way, they need to allow a json be defined without the corresponding .tsv[.gz] file, or allow empty tables (okay for .tsv but dangerous for .tsv.gz).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'm of course fine with the solution that fits best to BIDS in general but I agree that we should keep this information somehow.
allow a json be defined without the corresponding .tsv[.gz] file
would probably the best solution for this particular BEP as we agreed on .tsv.gz
```JSON | ||
{ | ||
"DeviceSerialNumber": "17535483", | ||
"Columns": ["timestamp", "x_coordinate", "y_coordinate", "pupil_size"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the src/schema/objects/columns.yaml and src/schema/rules/tabular_data/physio.yaml it says "et_timestamp", here it says "timestamp", which is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both are correct, these are two different things:
-
src/schema/objects/columns.yaml
,src/schema/rules/tabular_data/physio.yaml
define aet_timestamp
column name. This is so to allow the timestamp be different from the already existingtimestamp
column. This identifier is internal to the schema, so it does not propagate into actual column names. -
the line 672 you commented on is just the necessary specification of the
"Columns"
metadata, the column name is arbitrary, and in this case it is named"timestamp"
but other names would be equally supported.
Here is the specifications of the BEP 020 about eye tracking.
Note
We meet regularly and everyone is welcome :
Next meeting August 1st 2024 2pm CET on zoom.
Note that if you consider joining but this time or day doesn't suits you, reach me (@mszinte) and I will arrange another appointment.
Notes of last meeting
Chat and discussions also happening on matrix
Tip
HTML preview of this BEP
Issues for: