[FIX] Remove references to unspecified aslcontext.json #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1485 +/- ##
=======================================
Coverage 87.75% 87.75%
=======================================
Files 14 14
Lines 1282 1282
=======================================
Hits 1125 1125
Misses 157 157 ☔ View full report in Codecov by Sentry. |
tsalo
reviewed
May 3, 2023
Co-authored-by: Taylor Salo <tsalo90@gmail.com>
effigies
approved these changes
May 4, 2023
Comment on lines
+909
to
+911
| An anonymized screenshot of the planning of the labeling slab/plane | ||
| with respect to the imaging slab or slices. | ||
| This screenshot is based on DICOM macro C.8.13.5.14. |
There was a problem hiding this comment.
If we're going to copy directly from the schema, it would be better to move to something like:
{{ MACROS_render_text("objects.suffixes.asllabeling.description") }}There was a problem hiding this comment.
you mean creating a new macro then, right?
There was a problem hiding this comment.
I believe this relates to this:
#1038
|
I would suggest we wait for some ASL BEP lead to also approve this before merging. |
|
@patsycle @HenkMutsaerts In case you missed the review request... |
effigies
changed the title
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
HenkMutsaerts
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1479