Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] BEP 018 - Genetic Information #395

Merged
merged 58 commits into from Apr 9, 2020
Merged

[ENH] BEP 018 - Genetic Information #395

merged 58 commits into from Apr 9, 2020

Conversation

effigies
Copy link
Collaborator

This is an update of #287. I have merged master in and pushed to the bids-standard/bids-specification repository, which allows us to render the document here: https://bids-specification.readthedocs.io/en/bep018/04-modality-specific-files/08-genetic-descriptor.html

@CPernet If this works for you, then we can close #287, and future work can be done here, to ensure that other contributors can accept suggestions.

Cyril Pernet and others added 30 commits July 31, 2019 08:49
Co-Authored-By: Franklin Feingold <35307458+franklin-feingold@users.noreply.github.com>
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Fix Travis and spacing - merged changes
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
couldn't fix alignment in the GH editor
Co-Authored-By: Chris Markiewicz <markiewicz@stanford.edu>
@rwblair
Copy link
Member

rwblair commented Mar 27, 2020

@CPernet Changes to validator and examples allowing array for genetic level have been made:
bids-standard/bids-validator#934
bids-standard/bids-examples#179

@effigies
Copy link
Collaborator Author

@Arshitha I tried to apply the suggestion you gave, but it did not help.

@Arshitha
Copy link
Contributor

Arshitha commented Apr 2, 2020

@effigies
|----------------------------------------------------------|-----------------------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
replacing line 85 with above should do the trick since I don't have the permission to edit the file without creating a PR. I suggested 10 as an approx., but I'm trying to come up with a good convention for extending the table that isn't trial and error. However, for now, just extending the table by a large enough margin fixes the overlap.

If this doesn't work, I'll create a PR to fix it.

@effigies
Copy link
Collaborator Author

effigies commented Apr 3, 2020

It's a bit better. Realizing however that this will be the only three-column table. I'm going to reformat as two-column for consistency.

@effigies
Copy link
Collaborator Author

effigies commented Apr 7, 2020

Reduced to a two-column table. Still takes a huge number of extra spaces to get the left column not to overlap on the PDF. :-/

@CPernet CPernet closed this Apr 8, 2020
@CPernet CPernet reopened this Apr 8, 2020
CPernet
CPernet previously approved these changes Apr 8, 2020
sappelhoff
sappelhoff previously approved these changes Apr 8, 2020
@effigies
Copy link
Collaborator Author

effigies commented Apr 8, 2020

@CPernet https://www.ncbi.nlm.nih.gov/projects/gapsolr/facets.html now redirects to https://www.ncbi.nlm.nih.gov/gap/advanced_search/. Is this a simple renaming, or do we need to re-find the content you were previously trying to link to?

@CPernet
Copy link
Collaborator

CPernet commented Apr 8, 2020

people need to go under molecular datatype as indicated but there is no direct link so that's fine - leads to same page, thx

@effigies effigies dismissed stale reviews from sappelhoff and CPernet via 97d69ec April 8, 2020 17:00
@effigies
Copy link
Collaborator Author

effigies commented Apr 8, 2020

Okay. Now all green checks.

@CPernet CPernet merged commit 78a445a into master Apr 9, 2020
@effigies effigies deleted the bep018 branch April 17, 2020 18:13
@Remi-Gau Remi-Gau added the BEP label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants