New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] BEP 018 - Genetic Information #395
Conversation
BEP018 update
Co-Authored-By: Franklin Feingold <35307458+franklin-feingold@users.noreply.github.com>
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Fix Travis and spacing - merged changes
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
couldn't fix alignment in the GH editor
Co-Authored-By: Chris Markiewicz <markiewicz@stanford.edu>
@CPernet Changes to validator and examples allowing array for genetic level have been made: |
@Arshitha I tried to apply the suggestion you gave, but it did not help. |
@effigies If this doesn't work, I'll create a PR to fix it. |
It's a bit better. Realizing however that this will be the only three-column table. I'm going to reformat as two-column for consistency. |
Reduced to a two-column table. Still takes a huge number of extra spaces to get the left column not to overlap on the PDF. :-/ |
@CPernet https://www.ncbi.nlm.nih.gov/projects/gapsolr/facets.html now redirects to https://www.ncbi.nlm.nih.gov/gap/advanced_search/. Is this a simple renaming, or do we need to re-find the content you were previously trying to link to? |
people need to go under molecular datatype as indicated but there is no direct link so that's fine - leads to same page, thx |
Okay. Now all green checks. |
This is an update of #287. I have merged
master
in and pushed to thebids-standard/bids-specification
repository, which allows us to render the document here: https://bids-specification.readthedocs.io/en/bep018/04-modality-specific-files/08-genetic-descriptor.html@CPernet If this works for you, then we can close #287, and future work can be done here, to ensure that other contributors can accept suggestions.