[INFRA] ensure build_docs_pdf CircleCI job runs last

[sappelhoff]

follow up #433, which was apparently not sufficient. 😞

With this PR we ensure that build_docs_pdf runs only when all other jobs have successfully finished AND the current branch is master.

@franklin-feingold can we get this in despite your opening of #435 ?

[effigies]

This will make it hard to check PRs intended to improve the PDF.

[sappelhoff]

Thanks for the catch. The filter for master branch only is actually not necessary.

The branch to get the artifact from can be specified in the link as an appendix (see the ?branch=master):

https://circleci.com/api/v1.1/project/github/bids-standard/bids-specification/1957/artifacts/0/bids-spec.pdf?branch=master

[effigies]

Isn't the 1957 specifying the build number?

[sappelhoff]

Isn't the 1957 specifying the build number?

exactly. And with this PR I want to ensure that build_docs_pdf is always the last job run on circleCI ... so that we can replace 1957 with latest.

Then the link will be stable / work everytime (except for the times that circleCI is actively running on master, which it is rarely doing)

[effigies]

Got it. Thanks for putting up with my slowness. Can you add a comment to the config to explain why it depends on all other jobs? Otherwise we'll have to dig through the git-blame and find this discussion.

[franklin-feingold]

yup! we can squeeze this in. I think this is a nice addition to have for this release. I'll sync the release branch to master on the day of release

[sappelhoff]

The link is working as expected now :-)

https://circleci.com/api/v1.1/project/github/bids-standard/bids-specification/latest/artifacts/0/bids-spec.pdf?branch=master