Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] add metadata to PET calibration factor: "DoseCalibrationFactor" #825

Merged
merged 9 commits into from Jul 13, 2021
Merged

[ENH] add metadata to PET calibration factor: "DoseCalibrationFactor" #825

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
139079f
add calibration factor
CPernet Jul 5, 2021
a23ca24
CaibFact --> DoeCalibFact to recon table
CPernet Jul 6, 2021
d031620
fix table cell padding
mnoergaard Jul 6, 2021
41ae130
fix spelling
mnoergaard Jul 6, 2021
436a38a
fix table pipe alignment and description
mnoergaard Jul 6, 2021
2216ec9
better description of DoseCalibrationFactor
CPernet Jul 6, 2021
fbc7a8e
Merge branch 'master' of https://github.com/CPernet/bids-specification
CPernet Jul 6, 2021
0ad9c20
fix table pipe alignment
mnoergaard Jul 6, 2021
7319961
slight change of wording
sappelhoff Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/04-modality-specific-files/09-positron-emission-tomography.md
View file
Open in desktop
Expand Up @@ -213,6 +213,7 @@ We refer to the common principles for the standards for describing dates and tim
| ScaleFactor | RECOMMENDED | [array][] of [numbers][] | Scale factor for each frame. |
| ScatterFraction | RECOMMENDED | [array][] of [numbers][] | Scatter fraction for each frame (Units: 0-100%). |
| DecayCorrectionFactor | RECOMMENDED | [array][] of [numbers][] | Decay correction factor for each frame. |
| DoseCalibrationFactor | RECOMMENDED | [number][] | Value used to calibrate radioactivity count, i.e. transform to meaningful unit (e.g. Becquerel) - value already applied to the data as a multiplication factor that scales them from counts/sec to Bq/ml (dicom tag 0054,1322). |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have problems understanding the description. Could you please split this up into sentences with each sentence conveying a meaning?

Let me clarify what I find confusing:

Value used to calibrate radioactivity count

--> is "radioactivity count" metadata that corresponds to some already existing field? If yes, can you reference that one, please?

  • value already applied to the data as a multiplication factor that scales them from counts/sec to Bq/ml (dicom tag 0054,1322).

does that connect to the previous sentence? Or is it a standalone statement? Or an example / clarification?

Lastly:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out @sappelhoff. I have now updated the description, so it is very much in line with the dicom description, and then referring to the dicom tag. Then it is possible to make a dicom lookup, if one wants to search for more information. This also removes the latin abbreviations, and then I have aligned the table pipes.

| PromptRate | RECOMMENDED | [array][] of [numbers][] | Prompt rate for each frame (same units as `Units`, for example, `"Bq/mL"`). |
| RandomRate | RECOMMENDED | [array][] of [numbers][] | Random rate for each frame (same units as `Units`, for example, `"Bq/mL"`). |
| SinglesRate | RECOMMENDED | [array][] of [numbers][] | Singles rate for each frame (same units as `Units`, for example, `"Bq/mL"`). |
Expand Down