[INFRA] Enforce consistent line endings via .gitattributes #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
line_endings
branch
from
9c8bff1
to
69fea08
Compare
Remi-Gau
approved these changes
Aug 23, 2021
sappelhoff
reviewed
Aug 24, 2021
DimitriPapadopoulos
force-pushed
the
line_endings
branch
from
69fea08
to
510c8ed
Compare
16 tasks
sappelhoff
reviewed
Aug 24, 2021
Comment on lines
+2
to
+3
| *.png -text | ||
| *.jpg -text |
There was a problem hiding this comment.
The GitHub guide has the following for these lines:
# Denote all files that are truly binary and should not be modified.
*.png binary
*.jpg binary
Is -text equivalent? I think I find the GitHub way (together with the comment) more straight forward.
There was a problem hiding this comment.
I guess "not text" is the same as "binary". I just copied over from the source - the gitattributes documentation.
There was a problem hiding this comment.
Actually binary is equivalent to -text -diff. Since this patch is about line endings, I'd rather stick with the documentation.
sappelhoff
approved these changes
Aug 24, 2021
sappelhoff
changed the title
|
Thanks @DimitriPapadopoulos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in:
Fixes #860.