Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSV validation of missing values should consider empty cells #67

Closed
wtriplett opened this issue Dec 26, 2015 · 0 comments · Fixed by #68
Closed

TSV validation of missing values should consider empty cells #67

wtriplett opened this issue Dec 26, 2015 · 0 comments · Fixed by #68
Assignees
@wtriplett
Labels
enhancement

Comments

@wtriplett
Copy link

Validation currently only considers empty values that are specificed incorrectly, (e.g. NA, na, etc. instead of n/a), but cells/columns that contain no value (e.g. ) are not considered invalid empty values.
@wtriplett wtriplett self-assigned this Dec 26, 2015
wtriplett pushed a commit that referenced this issue Dec 26, 2015
Added validation for empty values as missing cells in TSV
ba3bb22 
Checks for empty cells and improperly specified missing values

Also unit tests added  for
1) empty cells (no value)
2) improperly specified missing values.

Potentially closes #67
@wtriplett wtriplett mentioned this issue Dec 26, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wtriplett wtriplett

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TSV validation fixes and potential enhancement bids-standard/bids-validator
1 participant
@wtriplett