Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation fails for subjects with labels with initial uppercase #873

Closed
effigies opened this issue Nov 22, 2019 · 2 comments
Closed

Validation fails for subjects with labels with initial uppercase #873

effigies opened this issue Nov 22, 2019 · 2 comments
Assignees

Comments

@effigies
Copy link
Collaborator

From Neurostars #5472:

The bids specification allows for upper case labels for subjects:

BIDS uses custom user-defined labels in several situations (naming of participants, sessions, acquisition schemes, etc.) Labels are strings and MUST only consist of letters (lower or upper case) and/or numbers.

However when i use upper case e.g sub-X01, the bids validator (http://bids-standard.github.io/bids-validator/) says error 1 “NOT_INCLUDED” and if i use sub-x01 then it passes. I think in this regard, the bids validator is therefore inconsistent with bids specification…

Best wishes,

Ollie Hulme

@effigies
Copy link
Collaborator Author

effigies commented Dec 2, 2019

Another user encountering this in Neurostars #5496.

Anybody know how to debug javascript?

@sappelhoff
Copy link
Member

I tried to replicate this on linux Ubuntu 18.04 with master validator and the eeg_matchingpennies example dataset.

  1. Validate using bids-validator eeg_matchingpennies/ --> all fine except for empty files
  2. Rename sub-05 in the dataset to sub-X01
  3. Validate --> same as step 1, ... no additional errors

furthermore given the status in

I assume that this problem has been solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants