Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove isCorrectModality function and its call in quicktest #1122

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

rwblair
Copy link
Member

@rwblair rwblair commented Dec 2, 2020

Quicktest looks to see if there was at least one file that either:

  1. had a .nii extension and was in a either a func, anat, or dwi directory
  2. had a json or tsv extension and was in any other accepted modality directory.

This is causing more problems that it solves:
https://neurostars.org/t/quick-validation-failed-on-physiological-files/17611

We now have regex to let users know what is a correctly or incorrectly formed filename. This PR makes quicktest just test that at least one subject session directory exists.

@rwblair rwblair merged commit 14c80a4 into master Dec 7, 2020
@effigies
Copy link
Collaborator

effigies commented Dec 7, 2020

Sorry, I maybe should have blocked this. I thought we'd decided it was appropriate to require at least one NIfTI file in func/?

@rwblair
Copy link
Member Author

rwblair commented Dec 7, 2020

We did, merging it was premature. I woke up this morning and the isCorrectModality code rubbed me the wrong way so I hit merge. It should be replaced at some point, guess it would be good to make a json/yaml way of denoting required files.

I'll revert and expand the quick validation error message to make it more transparent what exactly its looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants