Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] create lists for language, input type, data type for converters tables #261

Merged
merged 9 commits into from
Dec 12, 2022

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Nov 16, 2022

closes #248

@netlify
Copy link

netlify bot commented Nov 16, 2022

Deploy Preview for astounding-beignet-8ca2d6 ready!

Name Link
🔨 Latest commit 904f9bc
🔍 Latest deploy log https://app.netlify.com/sites/astounding-beignet-8ca2d6/deploys/6396ced4c07276000db0c712
😎 Deploy Preview https://deploy-preview-261--astounding-beignet-8ca2d6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sappelhoff
Copy link
Member

it's funny: clicking on the netlify deploy preview works pretty well --> UNTIL you click on the "benefits" tab ... which redirects you from the deploy PREVIEW to the actual deployment 😕 can you replicate this @Remi-Gau?

Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
@Remi-Gau
Copy link
Contributor Author

it's funny: clicking on the netlify deploy preview works pretty well --> UNTIL you click on the "benefits" tab ... which redirects you from the deploy PREVIEW to the actual deployment confused can you replicate this @Remi-Gau?

Yup I had seen that before even locally sometimes (I think).

@Remi-Gau
Copy link
Contributor Author

fyi the actual page would be this one:

https://deploy-preview-261--astounding-beignet-8ca2d6.netlify.app/benefits.html#mri-and-pet-converters

@Remi-Gau
Copy link
Contributor Author

seems to only affect the dropdown menu of the navbar

not sure why

@effigies
Copy link
Contributor

This table is extremely wide. On my laptop, the left/right borders are off the edge of my scrollable screen. On a large desktop monitor I can see everything.

I think we need something more compact.

@Remi-Gau
Copy link
Contributor Author

agreed this has been bugging me for a while actually

I have started playing with the CSS but not found something that would make it more manageable / readable if we keep some much info into the table.

@Remi-Gau
Copy link
Contributor Author

probably need to do the same about the BEP table

@effigies
Copy link
Contributor

I think there might be a solution with colored tags/badges and a legend. Modality, language, GUI, docs, license could all be represented very compactly.

@Remi-Gau
Copy link
Contributor Author

@effigies
Copy link
Contributor

Definitely more reasonably sized. I would also change the pypi and docker links to point to the projects on pypi and docker. We could also turn them into shields. Maybe it would make sense to just directly put the shield for the project into the YAML rather than rendering it on the fly with Jinja.

@Remi-Gau
Copy link
Contributor Author

Definitely more reasonably sized. I would also change the pypi and docker links to point to the projects on pypi and docker. We could also turn them into shields.

Will look into that.

Maybe it would make sense to just directly put the shield for the project into the YAML rather than rendering it on the fly with Jinja.

Not sure. Given that we use the repos url for other things (want to see if we can "easily" generate a page for each tool where all the info for this tool is displayed). So would not make that change just yet.

@Remi-Gau
Copy link
Contributor Author

@sappelhoff
Copy link
Member

nice! However, the conda badge doesn't say "conda", but when that conda package was "last updated", which is not the important information that users would need:

image

@Remi-Gau
Copy link
Contributor Author

nice! However, the conda badge doesn't say "conda", but when that conda package was "last updated", which is not the important information that users would need:

ouch I missed that bit.

will try to see if I can tweak that.

@Remi-Gau
Copy link
Contributor Author

nice! However, the conda badge doesn't say "conda", but when that conda package was "last updated", which is not the important information that users would need:

image

The badge should now display the version on anaconda.org.

@Remi-Gau Remi-Gau merged commit a2d1183 into bids-standard:gh-pages Dec 12, 2022
@Remi-Gau Remi-Gau deleted the converters branch December 12, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update date of last commit for each converter
3 participants