Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting several tasks fails #42

Closed
oesteban opened this issue May 17, 2017 · 3 comments
Closed

Selecting several tasks fails #42

oesteban opened this issue May 17, 2017 · 3 comments
Labels

Comments

@oesteban
Copy link
Collaborator

For a dataset with tasks 'rest' and 'view' this doesn't seem to work (or I am doing something wrong):

from bids.grabbids import BIDSLayout
layout = BIDSLayout('bids_dir/')
layout.get(task=['rest', 'view'])

I've tried changing the corresponding pattern (https://github.com/INCF/pybids/blob/master/bids/grabbids/config/bids.json#L25) to

        {
            "name": "task",
            "pattern": "task-([a-zA-Z0-9]+)"
        },

And it didn't work out either.

Selecting one task works well:

from bids.grabbids import BIDSLayout
layout = BIDSLayout('bids_dir/')
layout.get(task='rest')
@oesteban oesteban added the bug label May 17, 2017
oesteban added a commit to oesteban/mriqc that referenced this issue May 17, 2017
@chrisgorgo
Copy link
Contributor

@tyarkoni could you have a look at this?

@tyarkoni
Copy link
Collaborator

tyarkoni commented May 18, 2017

I don't think lists are supported for the task argument. That's worth adding, but I probably won't have time until early June. Should be fairly easy to add though if you want to open a PR, @oesteban. Alternatively, I think this is all regex based, so you can try task='rest|view' and that might work.

@tyarkoni
Copy link
Collaborator

Per grabbles/grabbit#36, lists now work as intended, so I'm closing this, @oesteban. Will be included in the next grabbit release.

oesteban added a commit to nipreps/nireports that referenced this issue Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants