Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Scale transformation fails if passed constant input. #614

Merged
merged 3 commits into from May 13, 2020

Conversation

tyarkoni
Copy link
Collaborator

Closes #578

@tyarkoni tyarkoni requested a review from adelavega May 13, 2020 00:35
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #614 into master will increase coverage by 0.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
+ Coverage   83.63%   84.39%   +0.76%     
==========================================
  Files          25       25              
  Lines        3196     3320     +124     
  Branches      810      886      +76     
==========================================
+ Hits         2673     2802     +129     
+ Misses        335      331       -4     
+ Partials      188      187       -1     
Flag Coverage Δ
#unittests 84.39% <100.00%> (+0.76%) ⬆️
Impacted Files Coverage Δ
bids/analysis/transformations/compute.py 88.79% <100.00%> (+2.06%) ⬆️
bids/layout/layout.py 88.31% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8823f...87fe039. Read the comment docs.

@tyarkoni tyarkoni merged commit 4cf7e4e into master May 13, 2020
@effigies effigies added this to the 0.11 milestone Jun 21, 2020
@effigies effigies deleted the fix-scale-na branch September 9, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scale transformation shouldn't return NAs in event of constant input
3 participants