New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable writing a meas_date event #32
Conversation
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 95.37% 95.39% +0.02%
==========================================
Files 3 3
Lines 216 217 +1
==========================================
+ Hits 206 207 +1
Misses 10 10
Continue to review full report at Codecov.
|
This is ready for merge (if you are OK with changing the meaning of |
Looks good to me, also that the meaning of "None" is changed. Can you please document this in https://github.com/bids-standard/pybv/blob/master/docs/changelog.rst ? After that, +1 to merge |
Alright, done (not sure if I got the authors list correct because I assumed you list only the authors contributing to a specific release - if all authors should be listed LMK). |
We are adding the "authors" section only with the release commit :-) so you can leave that empty for now and prior to the next release, we'll update it |
Understood - ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing the section
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
thanks @cbrnr ! |
Fixes #31.