Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable writing a meas_date event #32

Merged
merged 7 commits into from Aug 21, 2019

Conversation

cbrnr
Copy link
Collaborator

@cbrnr cbrnr commented Aug 21, 2019

Fixes #31.

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #32 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   95.37%   95.39%   +0.02%     
==========================================
  Files           3        3              
  Lines         216      217       +1     
==========================================
+ Hits          206      207       +1     
  Misses         10       10
Impacted Files Coverage Δ
pybv/io.py 92.9% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e9ff9...8da6ada. Read the comment docs.

@cbrnr
Copy link
Collaborator Author

cbrnr commented Aug 21, 2019

This is ready for merge (if you are OK with changing the meaning of meas_date=None).

@sappelhoff
Copy link
Member

Looks good to me, also that the meaning of "None" is changed.

Can you please document this in https://github.com/bids-standard/pybv/blob/master/docs/changelog.rst ?

After that, +1 to merge

@cbrnr
Copy link
Collaborator Author

cbrnr commented Aug 21, 2019

Alright, done (not sure if I got the authors list correct because I assumed you list only the authors contributing to a specific release - if all authors should be listed LMK).

@sappelhoff
Copy link
Member

We are adding the "authors" section only with the release commit :-) so you can leave that empty for now and prior to the next release, we'll update it

@cbrnr
Copy link
Collaborator Author

cbrnr commented Aug 21, 2019

Understood - ready!

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the section

docs/changelog.rst Outdated Show resolved Hide resolved
docs/changelog.rst Outdated Show resolved Hide resolved
cbrnr and others added 2 commits August 21, 2019 13:10
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
@sappelhoff sappelhoff merged commit 0bc32cc into bids-standard:master Aug 21, 2019
@sappelhoff
Copy link
Member

thanks @cbrnr !

@cbrnr cbrnr deleted the skip_measdate branch August 21, 2019 11:11
@cbrnr cbrnr mentioned this pull request Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exported file contains additional event
2 participants