Sampling interval can be float

[cbrnr]

Fixes #52. I've also introduced f-strings in this block of code - do you want me to convert the rest as well?

[codecov]

Codecov Report

Merging #59 (19a1c40) into master (f1aecaa) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   97.19%   97.26%   +0.07%     
==========================================
  Files           3        3              
  Lines         285      293       +8     
==========================================
+ Hits          277      285       +8     
  Misses          8        8              

Impacted Files	Coverage Δ
pybv/io.py	99.37% <100.00%> (ø)
pybv/tests/test_bv_writer.py	94.61% <100.00%> (+0.35%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1aecaa...19a1c40. Read the comment docs.

[sappelhoff]

Cool, thanks.

Can you please add a test covering a bunch of conventionally used sfreqs? (e.g. 512, 125, 100, 500, 1000, 1024, ...)

re: f-strings yes, would be nice! Preferably as a follow up PR though!

[sappelhoff]

Finally, please add a what's new entry --> I think this would fall under the "bug" category, WDYT?

[cbrnr]

@sappelhoff is this test OK?

[sappelhoff]

LGTM apart from my two suggestions.

If tests pass, this can be merged!

[cbrnr]

But do you think it's necessary to read the interval from the VHDR file and compare that with the inverse of the specified sampling frequency? Or do we just rely on MNE to do that during loading?

[sappelhoff]

But do you think it's necessary to read the interval from the VHDR file and compare that with the inverse of the specified sampling frequency? Or do we just rely on MNE to do that during loading?

I think ideally, we'd do both 🤔 but for now MNE is probably sufficient.

[sappelhoff]

Thanks @cbrnr if you are up to add a test with bare-python reading+checking the written sfreq, that'd be a nice addon :)