New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Improve file handling, add overwrite parameter #78
[MRG] Improve file handling, add overwrite parameter #78
Conversation
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 346 386 +40
=========================================
+ Hits 346 386 +40
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to my specific comments I was wondering if os.path
could also be replace by pathlib
not just in the tests but also in the rest of the code?
Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>
Yes, I thought about that myself. Would probably be prettier/clearer. Feel free to open an issue that then somebody can do at some point. |
Thanks @sappelhoff! |
closes #63
overwrite
parameter and set new default (False) --> previously pybv always overwrote files, which was a bit dangerous IMHOAlso adds tests for all of those