Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow event durations == 0 #96

Merged
merged 1 commit into from Jul 5, 2022

Conversation

cbrnr
Copy link
Collaborator

@cbrnr cbrnr commented Jul 5, 2022

Fixes #94.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #96 (f36c454) into main (8035d9b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #96   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          625       625           
=========================================
  Hits           625       625           
Impacted Files Coverage Δ
pybv/tests/test_bv_writer.py 100.00% <ø> (ø)
pybv/io.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8035d9b...f36c454. Read the comment docs.

@sappelhoff sappelhoff merged commit 10e938d into bids-standard:main Jul 5, 2022
@sappelhoff
Copy link
Member

Thanks! I'll make a release soon (latest friday)

@cbrnr cbrnr deleted the fix-event-duration branch July 5, 2022 20:29
@sappelhoff
Copy link
Member

https://pypi.org/project/pybv/0.7.4/ 🎉 the conda-forge release will be done with a bot via some webhook (I think), so that takes some more hours :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow event durations == 0
2 participants