Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCCP-174] Monitor internal call #69

Merged
merged 6 commits into from
Jul 18, 2023
Merged

[CCCP-174] Monitor internal call #69

merged 6 commits into from
Jul 18, 2023

Conversation

alstjd0921
Copy link
Member

@alstjd0921 alstjd0921 commented Jul 17, 2023 •
edited
Loading

Description

이전까지 Transaction의 to필드를 검사하여 relay 대상 이벤트를 감지했습니다.
이제부터 logs call 필터를 사용하여 internal call을 relay 대상 이벤트로 감지할 수 있습니다.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Something else (simple changes that are not related to existing functionality or others)

Checklist

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have made new test codes regarding to my changes.
  • I have no personal secrets or credentials described on my changes.
  • I have run cargo-clippy and linted my code.
  • My changes generate no new warnings.
  • My changes passed the existing test codes.
  • My changes are able to compile.

@alstjd0921 alstjd0921 added the bug Working incorrectly label Jul 17, 2023
@alstjd0921 alstjd0921 self-assigned this Jul 17, 2023
dnjscksdn98
dnjscksdn98 reviewed Jul 17, 2023
View reviewed changes
client/src/eth/blocks.rs Outdated Show resolved Hide resolved
client/src/eth/handlers/bridge_relay_handler.rs Outdated Show resolved Hide resolved
client/src/eth/blocks.rs Outdated Show resolved Hide resolved
client/src/eth/handlers/bridge_relay_handler.rs Show resolved Hide resolved
client/src/eth/handlers/bridge_relay_handler.rs Outdated Show resolved Hide resolved
@alstjd0921 alstjd0921 merged commit e047c14 into main Jul 18, 2023
@dnjscksdn98 dnjscksdn98 deleted the CCCP-174/theori-feedback branch July 18, 2023 05:03
SunoukMun pushed a commit that referenced this pull request Jun 12, 2024
@alstjd0921
[CCCP-174] Monitor internal call (#69)
075d48d 
* CCCP-174, fix: Edit block_manager to use log filter

* CCCP-174, chore: change get_logs parameter type to reference

* CCCP-174, fix: now block_manager deliver `Vec<Log>`

* CCCP-174, fix: Fit into new trait signatures

* CCCP-174, fix: Resolve pr conversations

* CCCP-174, fix: `get_transaction_receipt` error handling
SunoukMun pushed a commit that referenced this pull request Jun 14, 2024
@alstjd0921 @SunoukMun
[CCCP-174] Monitor internal call (#69)
a062cc2 
* CCCP-174, fix: Edit block_manager to use log filter

* CCCP-174, chore: change get_logs parameter type to reference

* CCCP-174, fix: now block_manager deliver `Vec<Log>`

* CCCP-174, fix: Fit into new trait signatures

* CCCP-174, fix: Resolve pr conversations

* CCCP-174, fix: `get_transaction_receipt` error handling
SunoukMun pushed a commit that referenced this pull request Jun 25, 2024
@alstjd0921 @SunoukMun
[CCCP-174] Monitor internal call (#69)
b13232e 
* CCCP-174, fix: Edit block_manager to use log filter

* CCCP-174, chore: change get_logs parameter type to reference

* CCCP-174, fix: now block_manager deliver `Vec<Log>`

* CCCP-174, fix: Fit into new trait signatures

* CCCP-174, fix: Resolve pr conversations

* CCCP-174, fix: `get_transaction_receipt` error handling
SunoukMun pushed a commit that referenced this pull request Jun 25, 2024
@alstjd0921 @SunoukMun
[CCCP-174] Monitor internal call (#69)
4626002 
* CCCP-174, fix: Edit block_manager to use log filter

* CCCP-174, chore: change get_logs parameter type to reference

* CCCP-174, fix: now block_manager deliver `Vec<Log>`

* CCCP-174, fix: Fit into new trait signatures

* CCCP-174, fix: Resolve pr conversations

* CCCP-174, fix: `get_transaction_receipt` error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnjscksdn98 dnjscksdn98 dnjscksdn98 approved these changes

Assignees

@alstjd0921 alstjd0921

Labels
bug Working incorrectly
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alstjd0921 @dnjscksdn98