Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCCP-247 feature, provide get logs batch size option #91

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

dnjscksdn98
Copy link
Member

@dnjscksdn98 dnjscksdn98 commented Sep 21, 2023

Description

Changes

  • eth_getLogs() 요청시 사용되는 batch size 조정이 가능한 옵션 제공
  • configuration에 존재하는 numeric한 값에 대한 디폴트 및 범위 검증 로직 추가

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Something else (simple changes that are not related to existing functionality or others)

Checklist

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have made new test codes regarding to my changes.
  • I have no personal secrets or credentials described on my changes.
  • I have run cargo-clippy and linted my code.
  • My changes generate no new warnings.
  • My changes passed the existing test codes.
  • My changes are able to compile.

@dnjscksdn98 dnjscksdn98 added the enhancement New feature or request label Sep 21, 2023
@dnjscksdn98 dnjscksdn98 self-assigned this Sep 21, 2023
@dnjscksdn98
Copy link
Member Author

추가된 커밋 확인 완료되었습니다~👍

Base automatically changed from CCCP-229-feature/balance-check-before-sending-transactions to main September 26, 2023 01:44
@dnjscksdn98 dnjscksdn98 force-pushed the CCCP-247-feature/provide-get-logs-batch-size-option branch from 0883588 to 02ef47c Compare September 26, 2023 01:48
@dnjscksdn98 dnjscksdn98 merged commit af70d74 into main Sep 26, 2023
@dnjscksdn98 dnjscksdn98 deleted the CCCP-247-feature/provide-get-logs-batch-size-option branch September 26, 2023 01:49
SunoukMun pushed a commit that referenced this pull request Jun 12, 2024
* CCCP-228, feature: verify provider chain ID on start

* CCCP-228, feature: verify BFC balance on start

* CCCP-247, feature: support eth_getLogs batch size option

* CCCP-247, feature: assert config parameters
SunoukMun pushed a commit that referenced this pull request Jun 14, 2024
* CCCP-228, feature: verify provider chain ID on start

* CCCP-228, feature: verify BFC balance on start

* CCCP-247, feature: support eth_getLogs batch size option

* CCCP-247, feature: assert config parameters
SunoukMun pushed a commit that referenced this pull request Jun 25, 2024
* CCCP-228, feature: verify provider chain ID on start

* CCCP-228, feature: verify BFC balance on start

* CCCP-247, feature: support eth_getLogs batch size option

* CCCP-247, feature: assert config parameters
SunoukMun pushed a commit that referenced this pull request Jun 25, 2024
* CCCP-228, feature: verify provider chain ID on start

* CCCP-228, feature: verify BFC balance on start

* CCCP-247, feature: support eth_getLogs batch size option

* CCCP-247, feature: assert config parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants