New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature reuest] Get phi as matrix #758

Closed
fedimser opened this Issue Feb 13, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@fedimser
Copy link
Contributor

fedimser commented Feb 13, 2017

When there are the same words in different modalities, we can't definetly restore phi from dataframe, and people have to do hacky things like saving several phi's for each modality.

We need fucntion like get_phi() in interface, but which returns array-like object, in which rows are ordered in accordance to word order in dictionary file (so I will be able to restore it definetly).

P.S. I know about get_phi().values, but it, in general case, randomly shuffles rows.

ofrei added a commit to ofrei/bigartm that referenced this issue Feb 13, 2017

@ofrei

This comment has been minimized.

Copy link
Contributor

ofrei commented Feb 13, 2017

@fedimser You are right, thanks for reporting this. May I ask you to review or test #759 and let me know if it it looks right? The change adds api ARTM.get_phi_dense that should solve this issue.

ofrei added a commit to ofrei/bigartm that referenced this issue Feb 27, 2017

@ofrei ofrei closed this in a8a568b Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment