Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for encoding Enzyme information into SDRF. #18

Merged
merged 6 commits into from
Aug 21, 2019
Merged

Proposal for encoding Enzyme information into SDRF. #18

merged 6 commits into from
Aug 21, 2019

Conversation

ypriverol
Copy link
Member

The following PR added new information about how to encode the Enzyme used into an SDRF:

  • It will follow the same approach that PTM information as key=value pairs.
  • It will enable to encode custom enzymes as long as well-annotated enzymes in PSI-MS.

Pending discussion: How to encode as regular expressions the Target Site in the sequence.

@StSchulze
Copy link
Collaborator

Inhibiting amino acids (like P) will be defined in the regular expression or should there rather be a separate key=value pair?

@ypriverol
Copy link
Member Author

ypriverol commented Aug 20, 2019

Inhibiting amino acids (like P) will be defined in the regular expression or should there rather be a separate key=value pair?

I think it can be defined in the regular expression. I been thinking that probably a goof catalog can be created and extended here: https://www.ebi.ac.uk/ols/ontologies/ms/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FMS_1001180

You guys @StSchulze and @mvaudel can help to implement the conversion from the specific name / regular expression into the specific Search engine parameters.

@StSchulze
Copy link
Collaborator

Inhibiting amino acids (like P) will be defined in the regular expression or should there rather be a separate key=value pair?

I think it can be defined in the regular expression. I been thinking that probably a goof catalog can be created and extended here: https://www.ebi.ac.uk/ols/ontologies/ms/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FMS_1001180

Sounds good to me, but the example should then be (?<=[KR])(?!P)

You guys @StSchulze and @mvaudel can help to implement the conversion from the specific name / regular expression into the specific Search engine parameters.

Yes, I'd be happy to follow up on that topic again!

@ypriverol
Copy link
Member Author

Inhibiting amino acids (like P) will be defined in the regular expression or should there rather be a separate key=value pair?

I think it can be defined in the regular expression. I been thinking that probably a goof catalog can be created and extended here: https://www.ebi.ac.uk/ols/ontologies/ms/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FMS_1001180

Sounds good to me, but the example should then be (?<=[KR])(?!P)

Fixed!!! Sorry to many things ongoing.

You guys @StSchulze and @mvaudel can help to implement the conversion from the specific name / regular expression into the specific Search engine parameters.

Yes, I'd be happy to follow up on that topic again!

experimental-design/README.adoc Show resolved Hide resolved
experimental-design/README.adoc Show resolved Hide resolved
experimental-design/README.adoc Outdated Show resolved Hide resolved
@trishorts
Copy link
Collaborator

I need to look at everything closely but I thought that I'd share what we do in MetaMorpheus to encode known and novel proteases. there are some REGEX notes for each.
| indicates cleavage site
[ ] indicates "preventing cleavage"
X indicates wildcard
{ } indicates exceptions to the wildcard
multiple-letter motifs are allowed

image

@trishorts
Copy link
Collaborator

you want that I should approve/merge?

@ypriverol
Copy link
Member Author

you want that I should approve/merge?

Yes, It would be great

@trishorts trishorts merged commit ea2820b into bigbio:master Aug 21, 2019
ypriverol pushed a commit that referenced this pull request May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants