Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Implement fix for overlapping social icon links in footer #117

Merged
merged 4 commits into from
Feb 5, 2019
Merged

Implement fix for overlapping social icon links in footer #117

merged 4 commits into from
Feb 5, 2019

Conversation

jaymcp
Copy link
Member

@jaymcp jaymcp commented Jan 17, 2019

Proposed Changes

  • Fix screen reader text issue causing icon width to be larger than is apparent
  • Remove superfluous styles from social icon elements

@jaymcp jaymcp added bug Something isn't working chore Task not related to a specific component or issue type labels Jan 17, 2019
@jaymcp jaymcp added this to the v1.1.0 milestone Jan 29, 2019
@scottblackburn scottblackburn merged commit d116ae5 into develop Feb 5, 2019
@jaymcp jaymcp deleted the hotfix/social-icons branch February 5, 2019 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scottblackburn scottblackburn scottblackburn approved these changes

Assignees
No one assigned
Labels
bug Something isn't working chore Task not related to a specific component or issue type
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jaymcp @scottblackburn