Replaced keepEvents with defaultKeepEvents and meetingKeepEvents #11681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobmarin
approved these changes
Mar 18, 2021
|
I followed up with @jfederico and he gave thumbs up to merge it! |
keevan
added a commit
to catalyst/moodle-mod_bigbluebuttonbn
that referenced
this pull request
Jun 3, 2021
keevan
added a commit
to catalyst/moodle-mod_bigbluebuttonbn
that referenced
this pull request
Jun 3, 2021
As per bigbluebutton/bigbluebutton#11681 and https://github.com/bigbluebutton/bigbluebutton.github.io/pull/239/files it seems that this new option was added to let the client control whether or not the data should be stored. The data needs to be stored if meeting stats are required so it can be sent back from the BBB server
keevan
added a commit
to catalyst/moodle-mod_bigbluebuttonbn
that referenced
this pull request
Jun 3, 2021
As per bigbluebutton/bigbluebutton#11681 and https://github.com/bigbluebutton/bigbluebutton.github.io/pull/239/files it seems that this new option was added to let the client control whether or not the data should be stored. The data needs to be stored if meeting stats are required so it can be sent back from the BBB server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows for meetings to override the
defaultKeepEventsproperty (formerlykeepEventsCreated property keepEvents at bbb-web to make redis record the event… #6385 ) by passingmeetingKeepEvents=trueorfalseI set
defaultKeepEventsto false, which is reverting enable post_events by default by setting keepEvents=true #10097 , cc @jfedericoNote that
defaultKeepEventsis only used in casemeetingKeepEventsis not passed.Closes Issue(s)
none
Motivation
We would like to have finer control over which meetings' events are recorded. Until now you would either keep events from all or none of the meetings
More