Created property keepEvents at bbb-web to make redis record the event… #6385
Conversation
…s for all meetings
| redis = BigBlueButton::RedisWrapper.new(redis_host, redis_port) | ||
| events_archiver = BigBlueButton::RedisEventsArchiver.new redis | ||
| events_xml = "#{events_dir}/#{meeting_id}/events.xml" | ||
| events = events_archiver.store_events(meeting_id, events_xml, break_timestamp) |
There was a problem hiding this comment.
Calling the store_events function multiple times with the same break timestamp is not safe, because it deletes the events for the segment after it writes the events.xml file.
You must ensure that store_events is only called once per break point.
In the case of a recorded meeting, I suggest running the normal archive script then copy events.xml to the events directory. Only call the events/events.rb script on non-recorded meetings.
There was a problem hiding this comment.
Ok. Thanks @kepstin ! I probably won't need to manually remove the events either, right? https://github.com/pedrobmarin/bigbluebutton/blob/keep-meeting-events/record-and-playback/core/scripts/events/events.rb#L66
There was a problem hiding this comment.
I recommend leaving that manual event removal code. That is supposed to be done after the final recording segment is saved - it removes some extra things in addition to events like meeting metadata and breakout room information.
| var props = msg.body.props.copy() | ||
| if (props.recordProp.keepEvents) { | ||
| val recordProp = msg.body.props.recordProp.copy(record = true) | ||
| props = msg.body.props.copy(recordProp = recordProp) |
There was a problem hiding this comment.
This sets the meeting as being recorded which would show the record interface on the client. Doesn't it?
I suggest to not override the record boolean but instead pass the keepEvent flag into the OutMsgRouter and let that decide to record the message or not.
This way the client doesn't have to know if the server is recording the events or not as it is not the client's concern,
There was a problem hiding this comment.
I'm sending the original record value to the MeetingCreatedEvtMsg builder and only overriding the RunningMeeting record. Tested with the HTML5 client and the interface matched the flag. Does the Flash client manages this differently? The messaging that flows after the MeetingCreatedEvtMsg can change this value or get it from RunningMeeting to feedback the clients?
There was a problem hiding this comment.
But I agree this is a little confusing. And I believe my test worked fine in the HTML5 client because Meteor saves everything in mongo... I'll make some changes. Thanks @ritzalam
|
I am good with the changes on akka-apps. Will wait for @kepstin to give a go ahead for merging. |
|
It looks like it's possible for a meeting to have both a "recorded" and an "ended" .done files created - in this case, the archiving will break. You need to ensure that the keep_events script and the archive script are never both run for the same meeting. |
|
I believe I tested this use case, but you might be right. I'll make some extra modifications in this pull request next week |
| @@ -513,6 +518,7 @@ private void processRemoveEndedMeeting(MeetingEnded message) { | |||
| if (m != null) { | |||
| m.setForciblyEnded(true); | |||
| processRecording(m); | |||
| if (keepEvents) recordingService.markAsEnded(m.getInternalId()); | |||
There was a problem hiding this comment.
@kepstin here is what we discussed about writing recorded tag before the ended tag. markAsEnded will generate the ended tag after the processRecording method. processRecording will call startIngestAndProcessing and generate the recorded tag. So we should be good to go.
There was a problem hiding this comment.
Can you just add a comment here to remark why the order is this way? Then everything should be good to go.
…s for all meetings
There are some scenarios where we would like to keep the events from all meetings. This is very useful to generate better usage reports for users.
The way we integrated this here is with a new property called
keepEventsinbbb-webthat can be enabled/disabled.When enabled,
bbb-webandakka-appswill use Redis' storage workflow to record events from all meetings (both recordable and not recordable).bbb-webwill tag the meetings asendedandrap-archivewill take an extra step digesting those events and saving in a separated folder/var/bigbluebutton/events. If the meeting was a not recordable meeting nothing else will happen in the recording process.When
keepEventsis disabled (it's default value) nothing changes from regular system behavior.