Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Add loading skeleton in userlist #14610

Merged

Conversation

ramonlsouza
Copy link
Member

@ramonlsouza ramonlsouza commented Mar 16, 2022

What does this PR do?

Implements a loading skeleton in userlist component that appears in the initial loading of users, using React Loading Skeleton.

Motivation

Initial load might take a while if user connection is slow or if many users are in the meeting, and see "Users: 0" and an empty userlist might confuse users. The loading skeleton is an indicator that content is still loading.

screen-recording-2022-03-18_15.47.29.mp4

@antobinary antobinary added this to the Release 2.5 milestone Mar 16, 2022
@tylercopeland
Copy link
Collaborator

@ramonlsouza great implementation!

A few small edit recommendations:

1 - Can we update the colour of the skeleton loader? I recommend we go with #DCE4EC
2 - Is it possible to match the spacing on the right-hand side with the left-hand side? That way, the skeleton visual isn't touching the edge of the side panel.

@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@antobinary antobinary merged commit 62657a3 into bigbluebutton:v2.5.x-release Mar 18, 2022
@prlanzarin
Copy link
Member

prlanzarin commented Mar 22, 2022

Suggestion (if feasible, otherwise ignore): make the number of skeleton items rendered be dynamic to a certain extent - eg render min(number_of_users, 10) skeleton users where 10 would be the max skeleton size (the current hardcoded value).

The rationale is that it's a bit inconsistent joining a meeting with ~3 people and have a skeleton user list with 10 skeleton users show up.

@ramonlsouza
Copy link
Member Author

ramonlsouza commented Mar 22, 2022

Suggestion (if feasible, otherwise ignore): make the number of skeleton items rendered be dynamic to a certain extent - eg render min(number_of_users, 10) skeleton users where 10 would be the max skeleton size (the current hardcoded value).

The rationale is that it's a bit inconsistent joining a meeting with ~3 people and have a skeleton user list with 10 skeleton users show up.

Thanks for the suggestion @prlanzarin! It would be a nice addition, but skeletons only appear when user data is being loaded for the first time (number_of_users is always zero when skeletons are active).

@antobinary antobinary changed the title Add loading skeleton in userlist style: Add loading skeleton in userlist Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants