chore: upgrade embedded tomcat to 9.0.62 #14733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antobinary
changed the title
antobinary
reviewed
Apr 4, 2022
bigbluebutton-web/build.gradle
Outdated
| @@ -72,6 +72,10 @@ dependencies { | |||
| implementation "org.grails.plugins:scaffolding" | |||
| implementation "org.grails.plugins:events" | |||
| implementation "org.grails.plugins:gsp" | |||
| implementation "org.apache.tomcat.embed:tomcat-embed-core:9.0.62" | |||
There was a problem hiding this comment.
Could we do
tomcat-embed-version "9.0.62" like we do for version
so that next time we have to upgrade it's a 1 line change and we don't miss any dependency
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes the version of embedded tomcat explicitly specified, thus also upgrading it
Motivation
Recently it has been reported that there is a voulnerability in security of spring. One option to to fix it,, according to announcement, is to have tomcat of version 9.0.62.
( https://spring.io/blog/2022/03/31/spring-framework-rce-early-announcement )
More
The issue was reported in #14719