Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge 2.6.0-alpha.1+ into develop #15316

Merged
merged 409 commits into from
Jul 4, 2022

Conversation

antobinary
Copy link
Member

Making sure all 2.6 fixes are available upstream

Tainan404 and others added 30 commits May 24, 2022 17:08
refactor: sidebar content panel UI polishing
`removeUser` was called with wrong parameters
fix(camera): prevent dock position change on click
Make sure do not show wrong data in user left message
...

styling external links inside the banner

Refactoring code

adding underline on hover and focus

removing hasLiink
…-style

style: Adding revised styles for our external links
Fix: voice users not removed from participants list
Use the built-in getLocalStream from the peer wrapper instead (which
relies on getSenders - the proper, spec-compliant way).

Two different issues are addressed:
  - RTCPeerConnection.getLocalStreams is a pre-1.0 WebRTC spec which is
    deprecated and not recommended.
  - Fixed an issue where a switch from full audio to listen only could
  cause the latter to be rejected with an error 1004 in rare scenarios.
…ecrit

fix(audio): remove deprecated getLocalStreams usage
antobinary and others added 28 commits June 29, 2022 11:04
chore: cleanup of Travis + a few random files
…d emoji button

The talking-indicator, emoji-button and input-live-stream-selector
components are passing props downstream that weren't omitted or handled
by inherited components (Button, Icon). That causes a handful of error
logs to be spammed in the console of dev environments, which is
annoying.

This commit addresses the issue by:
  - Making the talking, spoke, muted and isViewer props transient
    (styled-components) - which means they won't reach the DOM (as
    expected since they're style-only)
  - Omitting the EmojiButton `rotate` prop in the Icon component itself
    * Made that instead of transient because might be useful to migrate
      the rotate code to the Icon component?
Follow up to the cleanup done in 143d9bb
There are scenarios where the full audio broker (SFU) stop  procedure
may be called multiple times in a very short timestamp - eg a concurrent
stop + connection failure; a timeout in the transfer procedure + a
reconnect attempt, [...]. When that happens, calls to exitAudio may throw
errors if the broker was already released - and that's not the expected
behavior.
…leanup-transcoder

 refactor: remove akka-bbb-transcode leftovers
…llerId

feat: add user name to checkAuthorization response, [...]
…undef-broker-onstop

fix(audio): check if broker exists before trying to stop
…-audio-props

fix: omit unused props in talking-indicator, input stream selector and EmojiButton
…local-echo

chore(audio): enable local echo test and volume meter by default
…or-fix

Fix Cursor Not Updating For Mobile
Under some scenarios, cameras are freezing when the virtual background
code is running due to runPostProcessing(_renderMask) throwing
NS_ERROR_FAILURE - mainly on Firefox - consequently preventing
subsequent TimerWorker ticks from being scheduled.
Cases where I've seen that happen are:
  - conferences running under an iframe where the iframe is briefly
    stalled for some reason

Address the issue with a try-catch and a log for debugability (it's high
frequency, hence why not error level). We should probably remove the log
entirely once we figure out why the post-processing method is failing.
…-akka-file

reaf: Removes vertx-akka file added unnecessarily
…-background-thumb-Jun-30

improvement: virtual background selector thumbnail
fix(webcam): prevent camera freeze due to _renderMask exceptions
…ent-refactor-Jul-04

refactor: Icon component rotate info
…-shortcuts

fix: audio shortcuts regression
@antobinary antobinary merged commit 96c54a2 into bigbluebutton:develop Jul 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 5 Security Hotspots
Code Smell A 161 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet