-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Upgrade spring to 2.7.x #15467
fix: Upgrade spring to 2.7.x #15467
Conversation
Kudos, SonarCloud Quality Gate passed! |
This pull request has conflicts ☹ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the previous names for the configs to avoid break issues!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After your change the securitySalt
is being read from bigbluebutton.properties
instead of /etc/bigbluebutton/bbb-web.properties
.
All configs set on /etc/bigbluebutton/bbb-web.properties
have priority! Make sure to keep this behavior!
# Inject values into grails service beans | ||
beans.presentationService.presentationDir=${presentationDir} | ||
#presentationDir=${presentationDir} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer removing it instead of comment! If will not be necessary anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set to be as it used to
Co-authored-by: Gustavo Trott <gustavo@trott.com.br>
e96c899
to
0c735ed
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this PR do?
This PR upgrades version of spring to 2.7.x.Motivation
The newer version is more up to date and there are fixes that have been applied in Spring Boot 2.7To fix
The presentation is not being set as current Insert document request is not working properly Presentation is not displayed properlyMore
Note that we now specify versions explicitly for:
This was done to override the default
spring-core
andspring-context
included in Spring.The upgraded transitive dependencies include the following fixes: