fix(whiteboard): text annotations stuck as fake and re-adds right click to cancel #15619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 74c4c1c. Reverting this commit because it causes fake annotations from the text tool not to be removed. Since the text tool is the only one that generates fake annotations(because it is the only one that is live synced), the function to clear fake annotations is directly intended to clear them.
Cleans up and modifies the added annotation handler to suit only for text annotation. As soon as the DRAW_END message is sent, the local fake annotations are removed and replaced by the complete/not fake annotation.
Re-adds cancelling text annotation on right click. To achieve this, some mechanisms that were previously used to handle live synced annotations were rescued. So this partially reverts 40b18b0.
|
SonarCloud Quality Gate failed.
|
ramonlsouza
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
First, this PR reverts 74c4c1c because it causes fake annotations from the text tool not to be removed. Since the text tool is the only one that generates fake annotations(because it is the only one that is live synced), the function to clear fake annotations is directly intended to clear them.
Also this PR fixes 2 issues that are extremelly related:
Cleans up and modifies the added annotation handler to suit only for text annotation. As soon as the
DRAW_ENDmessage is sent, the local fake annotations are removed and replaced by the complete/not fake annotation.Re-adds cancelling text annotation on right click. To achieve this, some mechanisms that were previously used to handle live synced annotations were rescued. So this partially reverts 40b18b0.
Closes Issue(s)
Closes #15595
Closes #15458