Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: push layout #15657

Merged
merged 4 commits into from
Sep 27, 2022

Conversation

JoVictorNunes
Copy link
Collaborator

What does this PR do?

  • 84f9eee:
    • Extracts a new component to concetrate the push layout code.
    • Renames meeting layout variable names to be more clear.
  • acc55f0:
    • Doesn't allow moderators to propagate meeting layout info. Currently moderators can propagate meeting layout info, but the layout which is propagated is the presenter's, not their own. This can mislead the moderators because they think their layout is being propagated but it's not. It makes more sense to allow only presenters to propagate their layouts. (Push Layout with odd behavior #15574)

Closes Issue(s)

Closes #15574

Motivation

n/a

More

n/a

…button#15574). -- Currently moderators can propagate meeting layout info, but the layout which is propagated is the presenter's, not their own. This can mislead the moderators because they think their layout is being propagated but it's not. It makes more sense to allow only presenters to propagate their layouts.
@antobinary antobinary added this to the Release 2.6 milestone Sep 8, 2022
@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ramonlsouza ramonlsouza merged commit 089b64d into bigbluebutton:v2.6.x-release Sep 27, 2022
@lfzawacki
Copy link
Collaborator

This PR seems to have broken the propagation of camera/presentation size

@JoVictorNunes
Copy link
Collaborator Author

Thanks, @lfzawacki! I'm going to check this.

@einhirn
Copy link

einhirn commented Oct 11, 2022

It makes more sense to allow only presenters to propagate their layouts.

Actually there are use cases where it would make more sense for moderators to be able to push their layout - thinking of a conference or lecture, where a host or an assistant manages the BBB room and the presenter concentrates on their talk/lecture.

@lars-becker
Copy link

It makes more sense to allow only presenters to propagate their layouts.

Actually there are use cases where it would make more sense for moderators to be able to push their layout - thinking of a conference or lecture, where a host or an assistant manages the BBB room and the presenter concentrates on their talk/lecture.

Couldn't agree more. We often have guests / presenters who don't have much experience with BigBlueButton. Usually moderators assist them, which wouldn't work if only presenters can push layouts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants