handle missing cursor property case #15690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
KDSBrowne
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents malformed cursor position messages from being sent
Motivation
Due to cursor loading faster than whiteboard in certain cases it caused position messages to be sent with missing whiteboard ID resulting in
ERROR o.b.c.p.s.ReceivedJsonMsgHandlerActor - Failed to deserialize message Missing creator property 'whiteboardId' (index 0); 'DeserializationFeature.FAIL_ON_MISSING_CREATOR_PROPERTIES' enabledMore
Also it adds a log that lets user know that cursor position has not been sent
To reproduce