fix(whiteboard): Prevent Parent Id Crash when Erasing Grouped Shapes #16423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
ramonlsouza
requested changes
Jan 10, 2023
antobinary
changed the title
Comment on lines
+197
to
+200
| if (shapes[eid]?.type !== 'group') { | ||
| orderedDeletedShapes.unshift(eid); | ||
| } else { | ||
| orderedDeletedShapes.push(eid) |
There was a problem hiding this comment.
I think it has to be the reverse here, first delete the group shape, and then the children
There was a problem hiding this comment.
deleting the group shape first leads to the "shape has a parent that does not exist" error
| } | ||
| }); | ||
|
|
||
| removeShapes(orderedDeletedShapes, whiteboardId); |
There was a problem hiding this comment.
Also, I noticed we are sending empty removeAnnotations messages to akka when the list is empty here (probably it was already like this before).
There is no side-effect, but it's better to add a check if it's not empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR orders the id's of the shapes to be deleted, making sure the shapes of type group are removed last.
Motivation
Prevents the following parent id crash when deleting grouped shapes with the eraser.
