Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(whiteboard): prevent crashes when grouped shapes are removed #16543

Merged
merged 3 commits into from Jan 24, 2023
Merged

fix(whiteboard): prevent crashes when grouped shapes are removed #16543

merged 3 commits into from Jan 24, 2023

Conversation

ramonlsouza
Copy link
Member

@ramonlsouza ramonlsouza commented Jan 23, 2023 •
edited

What does this PR do?

Includes #16423 and more changes to prevent both of the following errors from happening when a grouped shape is removed:

  • a shape has a parent that does not exist
  • cannot read properties from undefined (reading 'id')

Closes Issue(s)

Closes #16428

@ramonlsouza ramonlsouza added this to the Release 2.6 milestone Jan 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ramonlsouza ramonlsouza merged commit 549fe98 into bigbluebutton:v2.6.x-release Jan 24, 2023
@ramonlsouza ramonlsouza mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tainan404 Tainan404 Tainan404 approved these changes

Assignees
No one assigned
Labels
priority: high
Projects
None yet
Milestone
Release 2.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ramonlsouza @Tainan404 @antobinary @KDSBrowne