fix: check for shape before shape.isLocked #16525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do the shape lock propery set in the container so the props change less times and avoid problems in the useMemo.
| @@ -270,7 +270,7 @@ export default function Whiteboard(props) { | |||
| } | |||
| // set shapes as locked for those who aren't allowed to edit it | |||
| Object.entries(shapes).forEach(([shapeId, shape]) => { | |||
| if (!shape.isLocked && !hasShapeAccess(shapeId)) { | |||
| if (shape &&!shape.isLocked && !hasShapeAccess(shapeId)) { | |||
There was a problem hiding this comment.
Suggested change
| if (shape &&!shape.isLocked && !hasShapeAccess(shapeId)) { | |
| if (shape && !shape.isLocked && !hasShapeAccess(shapeId)) { | |
|
I think would be better to move this code to the container so we don't need the check and don't change the shapes in the memo, since the shapes are a dependency. |
refactor(whiteboard): move shapelock to container + linting
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tries to avoid a whiteboard component crash logged as
isLocked of undefinedCloses Issue(s)
Closes # the issue is not reported yet
Motivation
More
Reported via screenshot on 2.6.0-beta.6