refactor(whiteboard): move shapelock to container + linting #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grails can handle CORS on its own. It just has to be configured in `/etc/bigbluebutton/bbb-web.properties`: ~~~ grails.cors.enabled=true grails.cors.allowedOrigins=https://bbb-proxy.example.org grails.cors.allowCredentials=true ~~~ This is a breaking change of the nginx config if (and only if) you run a cluster setup as described in https://docs.bigbluebutton.org/admin/clusterproxy.html **If** you run such a setup, you **need** to change `/etc/bigbluebutton/bbb-web.properties`. Otherwise users won't be able to join meetings, upload slides etc. The change in `PresentationController.groovy` fixes the handling of `OPTIONS` requests in the `/bigbluebutton/presentation/checkPresentation` handler.
translation completed for the source file '/bigbluebutton-html5/public/locales/en.json' on the 'gl' language.
translation completed for the source file '/bigbluebutton-html5/public/locales/en.json' on the 'ru' language.
translation completed for the source file '/bigbluebutton-html5/public/locales/en.json' on the 'es' language.
translation completed for the source file '/bigbluebutton-html5/public/locales/en.json' on the 'es_ES' language.
translation completed for the source file '/bigbluebutton-html5/public/locales/en.json' on the 'uk_UA' language.
…s_bigbluebutton-html5-public-locales-en-json--v2-6-x-release_gl Translate '/bigbluebutton-html5/public/locales/en.json' in 'gl'
…s_bigbluebutton-html5-public-locales-en-json--v2-6-x-release_ru Translate '/bigbluebutton-html5/public/locales/en.json' in 'ru'
…s_bigbluebutton-html5-public-locales-en-json--v2-6-x-release_es Translate '/bigbluebutton-html5/public/locales/en.json' in 'es'
…s_bigbluebutton-html5-public-locales-en-json--v2-6-x-release_es_ES Translate '/bigbluebutton-html5/public/locales/en.json' in 'es_ES'
…s_bigbluebutton-html5-public-locales-en-json--v2-6-x-release_uk_UA Translate '/bigbluebutton-html5/public/locales/en.json' in 'uk_UA'
test: Remove user
…eting-ended-error refactor: Improve error message on meeting or session invalid
Fix: use grails configuration for CORS settings
Co-authored-by: Gustavo Trott <gustavo@trott.com.br>
Do the shape lock propery set in the container so the props change less times and avoid problems in the useMemo.
antobinary
pushed a commit
that referenced
this pull request
Feb 1, 2023
Adjustments on choosing filename of the captured content
antobinary
pushed a commit
that referenced
this pull request
Dec 5, 2023
Fix hasPresentationUrlInParameter
antobinary
pushed a commit
that referenced
this pull request
Dec 5, 2023
test: Adds flaky flag to the presentation test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do the shape lock propery set in the container so the props change less times and avoid problems in the useMemo.
Apply linting fixes in the container file.
This is the relevant commit: 44692f9
The others are merge with updated 2.6.x-release