Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(whiteboard): Incorrect pen position after column resize #16564

Merged
merged 1 commit into from Jan 26, 2023
Merged

fix(whiteboard): Incorrect pen position after column resize #16564

merged 1 commit into from Jan 26, 2023

Conversation

ramonlsouza
Copy link
Member

What does this PR do?

Adjusts whiteboard draw position after resize.

Closes Issue(s)

Closes #16389

@ramonlsouza ramonlsouza added this to the Release 2.6 milestone Jan 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

KDSBrowne
KDSBrowne approved these changes Jan 26, 2023
View reviewed changes
Copy link
Collaborator

@KDSBrowne KDSBrowne left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The cursor position matches the position of newly created shapes after the presentation area is resized.

throttledResetCurrentPoint is a little confusing, but I gather it's just to force a re-render when the presentation area dimensions change.

@ramonlsouza ramonlsouza merged commit 775dfd0 into bigbluebutton:v2.6.x-release Jan 26, 2023
@ramonlsouza ramonlsouza mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KDSBrowne KDSBrowne KDSBrowne approved these changes

Assignees
No one assigned
Labels
priority: high
Projects
None yet
Milestone
Release 2.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ramonlsouza @KDSBrowne