Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove lockSettingsLockedLayout #16606

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

GuiLeme
Copy link
Collaborator

@GuiLeme GuiLeme commented Jan 31, 2023

What does this PR do?

It removes obsolete and deprecated lockSettingsLockedLayout and related settings.

Closes Issue(s)

Closes #13867

More

To test it, build bbb-common-message and bbb-common-web, and run bbb-web, akka-apps and bbb-html5

Since ConfigProps is also no longer used anywhere, I took the liberty to remove it from the code. Because of that, I might add that this PR is, now, related to #15118.

@GuiLeme GuiLeme changed the base branch from v2.6.x-release to develop February 8, 2023 14:32
@GuiLeme GuiLeme changed the base branch from develop to v2.6.x-release February 8, 2023 14:32
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gustavotrott gustavotrott self-requested a review February 8, 2023 16:48
@antobinary antobinary changed the title (refactor) - Remove lockSettingsLockedLayout refactor: Remove lockSettingsLockedLayout Feb 8, 2023
Copy link
Collaborator

@gustavotrott gustavotrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gustavotrott gustavotrott merged commit 375d1c5 into bigbluebutton:v2.6.x-release Feb 9, 2023
@gustavotrott
Copy link
Collaborator

TODO: Tweak the Docs

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants