Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow viewing of longer names in guest waiting queue #17084

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

zhem0004
Copy link
Contributor

@zhem0004 zhem0004 commented Mar 17, 2023

What does this PR do?

Improves usability of waiting user element by:
replacing buttons Message | Accept | Deny with icons to free up space for the name, also by making name capable of occupying multiple lines for more visibility

Screenshot from 2023-03-16 18-37-23

Closes Issue(s)

Closes #16390

Motivation

Previously the buttons used to cover the name on smaller screens which, especially on certain locales

More

PR removes background and cursor change on hovering over waiting user as it may mislead into thinking that user is clickable

@zhem0004 zhem0004 marked this pull request as draft March 17, 2023 13:24
@zhem0004 zhem0004 marked this pull request as ready for review March 17, 2023 13:43
@ramonlsouza ramonlsouza self-requested a review March 17, 2023 14:22
@antobinary antobinary changed the title redesign waiting user buttons fix: Allow viewing of longer names in guest waiting queue Mar 17, 2023
@antobinary antobinary added this to the Release 2.6 milestone Mar 17, 2023
@ramonlsouza ramonlsouza merged commit f8ce724 into bigbluebutton:v2.6.x-release Mar 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants