chore: Merge BBB ~2.6.1 into 2.7 #17365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bluebutton into whiteboard-tests-and-refactoring
bbb-webrtc-sfu is missing from the troubleshooting section. FreeSWITCH needs an update. The LXD section could reuse each subsection to avoid redundancy.
In a particular case where you have a large timestamp gap followed by a frame which re-initializes the filters in the pre-processing ffmpeg (e.g. due to a resolution change), the fps filter will keep generating frames to fill this gap even if downstream filters aren't accepting more frames. Add a trim filter which will eat the frames past the desired end timestamp to prevent them from getting queued up. Additionally, in cases with unlucky timing on the filter re-initialization, the pre-processing ffmpeg can end up generating some output past the set end time. Since the compositing ffmpeg exits once it has read enough input, this can cause the pre-processing ffmpeg to fail with a "Broken pipe" error. To work around this problem, the processing scripts themselves can open the pipe for reading to hold it open, and then send a signal to the pre-processing ffmpeg to tell it to exit. This results in ffmpeg exiting with the return code 255, which can be distinguished from actual errors. As a bonus, opening the fifo in the processing script allows increasing the size of the pipe buffer, which should result in slightly better performance.
A comparison was being done against the wrong variable, resulting in the empty string filename being added to the inactive videos list. This caused a crash later in the code.
Fix custom virtual background not being disabled when removed
fix: Close poll on slide change
Prevent URLs Triggering Typed Response Poll Option
recording: Fix video processing OOM, Broken pipe errors
…patch-2 chore: Bump bbb-playback to v5.0.0
bbb-presentation-video: Update to 4.0.1
100% translated for the source file 'bigbluebutton-html5/public/locales/en.json' on the 'fr' language. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
fix: empty slide on presentation change
…-push ci: Prevents CI triggering on push events
fix: fix some code smell by adding const for variables
fix(bbb-conf): switch to the safer .innerText
We were trying to save a poll result shape before it was converted to tldraw style, which was not compatible.
fix(recording): crash on redisrecorderactor when poll is published
fix(bbb-export-annotations): Change poll results appearance
backport of @hiroshisuga 's bigbluebutton#17363
Fix: Undo bug returning to slide '0'.
Fixed: Error message on layout change.
|
Kudos, SonarCloud Quality Gate passed!
|
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carrying forward fixes from 2.6.x