fix: recover drawing area (minimum version) #18084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
hiroshisuga
changed the title
ramonlsouza
approved these changes
Jun 5, 2023
antobinary
changed the title
|
Consider to rework this for Edge... :-( |
|
Quick fix (not tested but should work): -> const { isChrome, isEdge } = browserInfo; -> clipPath={ isChrome || isEdge ? "" : "url(#viewBox)" } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes a clippath that is making a problem on the recently updated Chromium-based browsers.
Closes Issue(s)
Closes #18066
Related discussion: https://groups.google.com/g/bigbluebutton-dev/c/r35CE7Z1zfU
Motivation
I need a quick fix because my class is starting from next week!
More
To me this clippath seems not necessary at all. I will post another PR (#18085) that removes all.
This PR itself might not be necessary if the bug (which I suppose so) is fixed on the Chromium side. But even so, removing this clippath does not harm anything as far as I checked.