[Fix 2.5] recover drawing area (drastic version) #18085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroshisuga
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
This pull request has conflicts ☹ |
|
Thank you! We went ahead with your other pull request instead - #18084 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes a clippath that is making a problem on the recently updated Chromium-based browsers. Different from #18084, this PR completely removes two clippath:url#viewbox that seem not necessary anymore.
Closes Issue(s)
Closes #18066
Related discussion: https://groups.google.com/g/bigbluebutton-dev/c/r35CE7Z1zfU
More
Compared to #18084, this PR may improve the performance because clippath needs quite a bit of PC resource. So far I don't find any problem with this PR, but I cannot test everything, needless to say.
I guess this clippath was indispensable in the early times to mask the drawing at outside of the viewbox, but during the development BBB has become more robust and able to eliminate the possibility of such outsiders by other means.