Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash script reads /etc/turnserver.conf to get realm and secret. #18184

Merged
merged 64 commits into from Mar 18, 2024

Conversation

debuglevel
Copy link
Contributor

@debuglevel debuglevel commented Jun 19, 2023

What does this PR do?

Small change to the bash script generating credentials for the TURN testing page.
It now reads credentials from the actual turn server configuration.

Closes Issue(s)

Closes #

Motivation

Just a little bit less copy and paste.

More

  • Added/updated documentation

antobinary and others added 30 commits July 18, 2022 20:02
fix: Poll question on slide not visible when Chrome's dark mode flag is enabled
translation completed updated for the source file '/bigbluebutton-html5/public/locales/en.json'
on the 'et' language.
…s_bigbluebutton-html5-public-locales-en-json--v2-5-x-release_et

Translate '/bigbluebutton-html5/public/locales/en.json' in 'et'
fix: Prevent Yes/No Quick Poll Without Options or Question (2.5)
fix(sec): Bump up grails web-boot and plugin-rest (backport)
fix(sec): bump nuProcess to 2.0.6 (backport)
fix(sec): bump jackson to 2.13.5; logback to 1.2.11 (backport)
chore: upgrade meteor to 2.10.0 (backport)
@welcome
Copy link

welcome bot commented Jun 19, 2023

Thank you for this contribution! Could you please confirm if you already sent in the signed Contributor License Agreement? See https://docs.bigbluebutton.org/support/faq.html#why-do-i-need-to-sign-a-contributor-license-agreement-to-contribute-source-code Thanks in advance!

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@antobinary antobinary changed the base branch from main to v2.6.x-release June 19, 2023 14:30
@antobinary antobinary changed the base branch from v2.6.x-release to main June 19, 2023 14:35
@antobinary
Copy link
Member

Hi @debuglevel ,
Thank you for this contribution!
Just a note to whoever is merging this that it should go into branch v2.6.x-release

Copy link

stale bot commented Mar 16, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label Mar 16, 2024
@antobinary antobinary self-requested a review March 18, 2024 15:20
@antobinary antobinary added this to the Release 3.0 milestone Mar 18, 2024
@antobinary antobinary changed the base branch from main to v2.7.x-release March 18, 2024 20:17
Copy link
Member

@antobinary antobinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the branch and doing a bit of cleanup

@antobinary antobinary merged commit 990daee into bigbluebutton:v2.7.x-release Mar 18, 2024
2 checks passed
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

antobinary pushed a commit to antobinary/bigbluebutton that referenced this pull request Mar 18, 2024
…bigbluebutton#18184)

* bash script reads /etc/turnserver.conf to get realm and secret.
antobinary added a commit that referenced this pull request Mar 18, 2024
…#18184) (#19843) (port)

* bash script reads /etc/turnserver.conf to get realm and secret.

Co-authored-by: Marc Kohaupt <debuglevel@gmail.com>
Copy link

Automated tests Summary

All the CI tests have passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants