Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for presence of parentMeetingID if isBreakout is true #18975

Merged
merged 1 commit into from Oct 19, 2023
Merged

fix: check for presence of parentMeetingID if isBreakout is true #18975

merged 1 commit into from Oct 19, 2023

Conversation

Ithanil
Copy link
Contributor

@Ithanil Ithanil commented Oct 19, 2023 •
edited

What does this PR do

Fix the check for presence of parentMeetingID when isBreakout is true. There were two problems:

  1. The first part of the if-clause would always be true when isBreakout was set to any value. It should only be true when isBreakout is passed as true. This is achieved by checking isBreakout == "true".
  2. The second part of the if-clause used the parameter "parentIdMeetingId", but the correct parameter according to API Docs is parentMeetingID . The parameter has been renamed appropriately.

For more details on the effect of these problems see the linked issue.

Closes Issue(s)

Closes #18961

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell C 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Ithanil Ithanil changed the title fix check for presence of parentMeetingId if isBreakout is true fix check for presence of parentMeetingID if isBreakout is true Oct 19, 2023
@antobinary antobinary added this to the Release 2.7 milestone Oct 19, 2023
@antobinary
Copy link
Member

Thank you for filing an issue and submitting its fix, @Ithanil !!

@antobinary antobinary changed the title fix check for presence of parentMeetingID if isBreakout is true fix: check for presence of parentMeetingID if isBreakout is true Oct 19, 2023
@antobinary antobinary merged commit d24cdfd into bigbluebutton:v2.7.x-release Oct 19, 2023
22 of 24 checks passed
@Ithanil Ithanil deleted the fix_isbreakout_api branch October 19, 2023 18:40
@github-actions
Copy link

Automated tests Summary

🚨 Test workflow has failed

Click here to check the action test reports

@antobinary antobinary mentioned this pull request Oct 19, 2023
Merged
@Scroody Scroody mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paultrudel paultrudel paultrudel approved these changes

Assignees
No one assigned
Labels
cla: signed
Projects
None yet
Milestone
Release 2.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ithanil @antobinary @paultrudel